public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "kristerw at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/113703] New: ivopts miscompiles loop Date: Thu, 01 Feb 2024 11:17:00 +0000 [thread overview] Message-ID: <bug-113703-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113703 Bug ID: 113703 Summary: ivopts miscompiles loop Product: gcc Version: 14.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: tree-optimization Assignee: unassigned at gcc dot gnu.org Reporter: kristerw at gcc dot gnu.org Target Milestone: --- The following function (gcc.dg/tree-ssa/ivopts-lt.c) is miscompiled when compiled with with -O1 for X86_64: #include "stdint.h" void f1 (char *p, uintptr_t i, uintptr_t n) { p += i; do { *p = '\0'; p += 1; i++; } while (i < n); } The IR after cunroll looks like: void f1 (char * p, uintptr_t i, uintptr_t n) { <bb 2>: p_6 = p_4(D) + i_5(D); <bb 3>: # p_1 = PHI <p_6(2), p_9(5)> # i_2 = PHI <i_5(D)(2), i_10(5)> *p_1 = 0; p_9 = p_1 + 1; i_10 = i_2 + 1; if (i_10 < n_11(D)) goto <bb 5>; else goto <bb 4>; <bb 5>: goto <bb 3>; <bb 4>: return; } This is then changed by ivopts to void f1 (char * p, uintptr_t i, uintptr_t n) { sizetype _13; char * _14; <bb 2>: p_6 = p_4(D) + i_5(D); _13 = n_11(D) - i_5(D); _14 = p_6 + _13; <bb 3>: # p_1 = PHI <p_6(2), p_9(5)> MEM[(char *)p_1] = 0; p_9 = p_1 + 1; if (p_9 < _14) goto <bb 5>; else goto <bb 4>; <bb 5>: goto <bb 3>; <bb 4>: return; } Suppose the function gets called with the values: p = 0x0002ffffffffffff i = 0xffff000000000001 n = 0xdffd7fffffffffff The original function writes 0 to address 0x0002000000000000, and then exits. The optimized function overflows when calculating _14, and the function does the equivalent of memset(0x0002000000000000, 0, 0xdffe7ffffffffffe);
next reply other threads:[~2024-02-01 11:17 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-01 11:17 kristerw at gcc dot gnu.org [this message] 2024-02-01 14:12 ` [Bug tree-optimization/113703] " rguenth at gcc dot gnu.org 2024-02-01 15:01 ` kristerw at gcc dot gnu.org 2024-02-01 15:30 ` kristerw at gcc dot gnu.org 2024-02-05 10:04 ` rguenth at gcc dot gnu.org 2024-02-06 11:33 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-113703-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).