public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/113708] [modules] ICE in import_export_decl with non-trivially initialized inline variable in header module
Date: Wed, 14 Feb 2024 19:08:13 +0000	[thread overview]
Message-ID: <bug-113708-4-yvPJS0V2f4@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113708-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113708

--- Comment #1 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Nathaniel Shead <nshead@gcc.gnu.org>:

https://gcc.gnu.org/g:dd9d14f7d53de07beff06004922a2bff20ece671

commit r14-8987-gdd9d14f7d53de07beff06004922a2bff20ece671
Author: Nathaniel Shead <nathanieloshead@gmail.com>
Date:   Wed Feb 14 12:26:03 2024 +1100

    c++: Defer emitting inline variables [PR113708]

    Inline variables are vague-linkage, and may or may not need to be
    emitted in any TU that they are part of, similarly to e.g. template
    instantiations.

    Currently 'import_export_decl' assumes that inline variables have
    already been emitted when it comes to end-of-TU processing, and so
    crashes when importing non-trivially-initialised variables from a
    module, as they have not yet been finalised.

    This patch fixes this by ensuring that inline variables are always
    deferred till end-of-TU processing, unifying the behaviour for module
    and non-module code.

            PR c++/113708

    gcc/cp/ChangeLog:

            * decl.cc (make_rtl_for_nonlocal_decl): Defer inline variables.
            * decl2.cc (import_export_decl): Support inline variables.

    gcc/testsuite/ChangeLog:

            * g++.dg/debug/dwarf2/inline-var-1.C: Reference 'a' to ensure it
            is emitted.
            * g++.dg/debug/dwarf2/inline-var-3.C: Likewise.
            * g++.dg/modules/init-7_a.H: New test.
            * g++.dg/modules/init-7_b.C: New test.

    Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>

  reply	other threads:[~2024-02-14 19:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01 18:00 [Bug c++/113708] New: " ppalka at gcc dot gnu.org
2024-02-14 19:08 ` cvs-commit at gcc dot gnu.org [this message]
2024-02-14 19:09 ` [Bug c++/113708] " nshead at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113708-4-yvPJS0V2f4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).