public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/113731] [14 regression] ICE when building libbsd since r14-8768-g85094e2aa6dba7
Date: Wed, 07 Feb 2024 10:59:01 +0000	[thread overview]
Message-ID: <bug-113731-4-yfg1icPLvR@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113731-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113731

--- Comment #11 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>:

https://gcc.gnu.org/g:8f6ed71d8fff3c3c6249651a72aee084e31ffb9e

commit r14-8839-g8f6ed71d8fff3c3c6249651a72aee084e31ffb9e
Author: Tamar Christina <tamar.christina@arm.com>
Date:   Wed Feb 7 10:58:25 2024 +0000

    middle-end: fix ICE when moving statements to empty BB [PR113731]

    We use gsi_move_before (&stmt_gsi, &dest_gsi); to request that the new
statement
    be placed before any other statement.  Typically this then moves the
current
    pointer to be after the statement we just inserted.

    However it looks like when the BB is empty, this does not happen and the
CUR
    pointer stays NULL.   There's a comment in the source of gsi_insert_before
that
    explains:

    /* If CUR is NULL, we link at the end of the sequence (this case happens

    This adds a default parameter to gsi_move_before to allow us to control
where
    the insertion happens.

    gcc/ChangeLog:

            PR tree-optimization/113731
            * gimple-iterator.cc (gsi_move_before): Take new parameter for
update
            method.
            * gimple-iterator.h (gsi_move_before): Default new param to
            GSI_SAME_STMT.
            * tree-vect-loop.cc (move_early_exit_stmts): Call gsi_move_before
with
            GSI_NEW_STMT.

    gcc/testsuite/ChangeLog:

            PR tree-optimization/113731
            * gcc.dg/vect/vect-early-break_111-pr113731.c: New test.

  parent reply	other threads:[~2024-02-07 10:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-02 22:11 [Bug middle-end/113731] New: [14 regression] ICE when building libbsd sjames at gcc dot gnu.org
2024-02-02 22:14 ` [Bug middle-end/113731] " sjames at gcc dot gnu.org
2024-02-02 22:41 ` sjames at gcc dot gnu.org
2024-02-02 22:53 ` sjames at gcc dot gnu.org
2024-02-02 23:08 ` pinskia at gcc dot gnu.org
2024-02-03  7:36 ` [Bug middle-end/113731] [14 regression] ICE when building libbsd since r14-8768-g85094e2aa6dba7 tnfchris at gcc dot gnu.org
2024-02-03  7:50 ` sjames at gcc dot gnu.org
2024-02-05 15:12 ` [Bug tree-optimization/113731] " tnfchris at gcc dot gnu.org
2024-02-07  3:08 ` sjames at gcc dot gnu.org
2024-02-07  9:03 ` doko at gcc dot gnu.org
2024-02-07  9:08 ` tnfchris at gcc dot gnu.org
2024-02-07 10:00 ` burnus at gcc dot gnu.org
2024-02-07 10:59 ` cvs-commit at gcc dot gnu.org [this message]
2024-02-07 11:00 ` tnfchris at gcc dot gnu.org
2024-02-07 21:00 ` sjames at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113731-4-yfg1icPLvR@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).