public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/113750] [14 Regression] ICE in vect building gcc/m2/gm2-libs/NumberIO.mod since r14-8769-g64b0130bb6702c
Date: Wed, 07 Feb 2024 10:59:58 +0000	[thread overview]
Message-ID: <bug-113750-4-0jNGi32nfb@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113750-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113750

--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>:

https://gcc.gnu.org/g:5c3ba60024fedc6b3d374ebb071bcf5b3e27cd62

commit r14-8840-g5c3ba60024fedc6b3d374ebb071bcf5b3e27cd62
Author: Tamar Christina <tamar.christina@arm.com>
Date:   Wed Feb 7 10:59:32 2024 +0000

    middle-end: fix ICE when destination BB for stores starts with a label
[PR113750]

    The report shows that if the FE leaves a label as the first thing in the
dest
    BB then we ICE because we move the stores before the label.

    This is easy to fix if we know that there's still only one way into the BB.
    We would have already rejected the loop if there was multiple paths into
the BB
    however I added an additional check just for early break in case the other
    constraints are relaxed later with an explanation.

    After that we fix the issue just by getting the GSI after the labels and I
add
    a bunch of testcases for different positions the label can be added.  Only
the
    vect-early-break_112-pr113750.c one results in the label being kept.

    gcc/ChangeLog:

            PR tree-optimization/113750
            * tree-vect-data-refs.cc (vect_analyze_early_break_dependences):
Check
            for single predecessor when doing early break vect.
            * tree-vect-loop.cc (move_early_exit_stmts): Get gsi at the start
but
            after labels.

    gcc/testsuite/ChangeLog:

            PR tree-optimization/113750
            * gcc.dg/vect/vect-early-break_112-pr113750.c: New test.
            * gcc.dg/vect/vect-early-break_113-pr113750.c: New test.
            * gcc.dg/vect/vect-early-break_114-pr113750.c: New test.
            * gcc.dg/vect/vect-early-break_115-pr113750.c: New test.
            * gcc.dg/vect/vect-early-break_116-pr113750.c: New test.

  parent reply	other threads:[~2024-02-07 10:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-03 21:07 [Bug middle-end/113750] New: [14 Regression] ICE in vect building gcc/m2/gm2-libs/NumberIO.mod iains at gcc dot gnu.org
2024-02-03 21:08 ` [Bug middle-end/113750] " pinskia at gcc dot gnu.org
2024-02-03 23:33 ` iains at gcc dot gnu.org
2024-02-04 11:51 ` gaius at gcc dot gnu.org
2024-02-04 14:41 ` iains at gcc dot gnu.org
2024-02-04 14:42 ` iains at gcc dot gnu.org
2024-02-05  1:07 ` [Bug middle-end/113750] [14 Regression] ICE in vect building gcc/m2/gm2-libs/NumberIO.mod since r14-8769-g64b0130bb6702c sjames at gcc dot gnu.org
2024-02-05  7:32 ` tnfchris at gcc dot gnu.org
2024-02-07 10:59 ` cvs-commit at gcc dot gnu.org [this message]
2024-02-07 11:01 ` [Bug tree-optimization/113750] " tnfchris at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113750-4-0jNGi32nfb@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).