From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 30B9D385DC2E; Fri,  8 Mar 2024 23:48:22 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 30B9D385DC2E
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1709941703;
	bh=1FJLLqBuROrSF87YndelHMt9aPI7dCwYtyF8K0ln9tc=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=mFcrxN1bIxyPz4X11MYIHer7UQ/3NX2382Na5djFAhxbR6fnof27TxMjXs63ZdT/+
	 O+CLiPzeSA8Va9seyhJkZy0zG8bXN06tLPr64bMsZRCOwlP45RLgUfdjfqEePzQdFv
	 q5IZRArTonF3FCckLXtfRRHC1Zeo6HuwKN/C7RhY=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/113757] [14 regression] ICE when building
 legion-23.03.0 since r14-8398
Date: Fri, 08 Mar 2024 23:48:21 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: jamborm at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-113757-4-R6bufXli5c@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-113757-4@http.gcc.gnu.org/bugzilla/>
References: <bug-113757-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113757

--- Comment #9 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Jambor <jamborm@gcc.gnu.org>:

https://gcc.gnu.org/g:54e505d0446f86b7ad383acbb8e5501f20872b64

commit r14-9403-g54e505d0446f86b7ad383acbb8e5501f20872b64
Author: Martin Jambor <mjambor@suse.cz>
Date:   Sat Mar 9 00:47:22 2024 +0100

    ipa: Avoid excessive removing of SSAs (PR 113757)

    PR 113757 shows that the code which was meant to debug-reset and
    remove SSAs defined by LHSs of calls redirected to
    __builtin_unreachable can trigger also when speculative
    devirtualization creates a call to a noreturn function (and since it
    is noreturn, it does not bother dealing with its return value).

    What is more, it seems that the code handling this case is not really
    necessary.  I feel slightly idiotic about this because I have a
    feeling that I added it because of a failing test-case but I can
    neither find the testcase nor a reason why the code in
    cgraph_edge::redirect_call_stmt_to_callee would not be sufficient (it
    turns the SSA name into a default-def, a bit like IPA-SRA, but any
    code dominated by a call to a noreturn is not dangerous when it comes
    to its side-effects).  So this patch just removes the handling.

    gcc/ChangeLog:

    2024-02-07  Martin Jambor  <mjambor@suse.cz>

            PR ipa/113757
            * tree-inline.cc (redirect_all_calls): Remove code adding SSAs =
to
            id->killed_new_ssa_names.

    gcc/testsuite/ChangeLog:

    2024-02-07  Martin Jambor  <mjambor@suse.cz>

            PR ipa/113757
            * g++.dg/ipa/pr113757.C: New test.=