* [Bug c++/113757] [14 regression] ICE when building legion-23.03.0
2024-02-04 20:29 [Bug c++/113757] New: [14 regression] ICE when building legion-23.03.0 sjames at gcc dot gnu.org
@ 2024-02-04 20:36 ` sjames at gcc dot gnu.org
2024-02-04 20:42 ` sjames at gcc dot gnu.org
` (11 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: sjames at gcc dot gnu.org @ 2024-02-04 20:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113757
--- Comment #1 from Sam James <sjames at gcc dot gnu.org> ---
I will try reduce it but my track record with C++ isn't good ;)
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug c++/113757] [14 regression] ICE when building legion-23.03.0
2024-02-04 20:29 [Bug c++/113757] New: [14 regression] ICE when building legion-23.03.0 sjames at gcc dot gnu.org
2024-02-04 20:36 ` [Bug c++/113757] " sjames at gcc dot gnu.org
@ 2024-02-04 20:42 ` sjames at gcc dot gnu.org
2024-02-04 20:59 ` [Bug tree-optimization/113757] " pinskia at gcc dot gnu.org
` (10 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: sjames at gcc dot gnu.org @ 2024-02-04 20:42 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113757
--- Comment #2 from Sam James <sjames at gcc dot gnu.org> ---
needs -O2 -march=znver2 -fPIC (the znver2 is just an artefact of how I built it
though, didn't bother trying it without w/o preprocessed)
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug tree-optimization/113757] [14 regression] ICE when building legion-23.03.0
2024-02-04 20:29 [Bug c++/113757] New: [14 regression] ICE when building legion-23.03.0 sjames at gcc dot gnu.org
2024-02-04 20:36 ` [Bug c++/113757] " sjames at gcc dot gnu.org
2024-02-04 20:42 ` sjames at gcc dot gnu.org
@ 2024-02-04 20:59 ` pinskia at gcc dot gnu.org
2024-02-04 21:11 ` pinskia at gcc dot gnu.org
` (9 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-02-04 20:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113757
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |14.0
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug tree-optimization/113757] [14 regression] ICE when building legion-23.03.0
2024-02-04 20:29 [Bug c++/113757] New: [14 regression] ICE when building legion-23.03.0 sjames at gcc dot gnu.org
` (2 preceding siblings ...)
2024-02-04 20:59 ` [Bug tree-optimization/113757] " pinskia at gcc dot gnu.org
@ 2024-02-04 21:11 ` pinskia at gcc dot gnu.org
2024-02-04 22:19 ` [Bug tree-optimization/113757] [14 regression] ICE when building legion-23.03.0 since r14-8398 jakub at gcc dot gnu.org
` (8 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-02-04 21:11 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113757
--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Sam James from comment #1)
> I will try reduce it but my track record with C++ isn't good ;)
I am reducing it too.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug tree-optimization/113757] [14 regression] ICE when building legion-23.03.0 since r14-8398
2024-02-04 20:29 [Bug c++/113757] New: [14 regression] ICE when building legion-23.03.0 sjames at gcc dot gnu.org
` (3 preceding siblings ...)
2024-02-04 21:11 ` pinskia at gcc dot gnu.org
@ 2024-02-04 22:19 ` jakub at gcc dot gnu.org
2024-02-05 3:28 ` sjames at gcc dot gnu.org
` (7 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-02-04 22:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113757
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Last reconfirmed| |2024-02-04
Summary|[14 regression] ICE when |[14 regression] ICE when
|building legion-23.03.0 |building legion-23.03.0
| |since r14-8398
CC| |jakub at gcc dot gnu.org
Status|UNCONFIRMED |NEW
Priority|P3 |P1
--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with r14-8398-ga9a8426e534760b8d3a250e9bd3cff4db131a2be
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug tree-optimization/113757] [14 regression] ICE when building legion-23.03.0 since r14-8398
2024-02-04 20:29 [Bug c++/113757] New: [14 regression] ICE when building legion-23.03.0 sjames at gcc dot gnu.org
` (4 preceding siblings ...)
2024-02-04 22:19 ` [Bug tree-optimization/113757] [14 regression] ICE when building legion-23.03.0 since r14-8398 jakub at gcc dot gnu.org
@ 2024-02-05 3:28 ` sjames at gcc dot gnu.org
2024-02-05 3:59 ` pinskia at gcc dot gnu.org
` (6 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: sjames at gcc dot gnu.org @ 2024-02-05 3:28 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113757
--- Comment #5 from Sam James <sjames at gcc dot gnu.org> ---
reduced but with return-type UB:
```
template <typename _Alloc> struct __alloc_traits {
typedef typename _Alloc::value_type &const_reference;
};
struct LegionAllocator {
typedef int value_type;
};
struct vector {
long size() const;
__alloc_traits<LegionAllocator>::const_reference operator[](long) const;
};
void __assert_fail();
template <typename> using LegionVector = vector;
struct TaskOp {
virtual int &get_version_info();
} *slice_owner;
struct PointTask {
virtual const int &get_version_info() const;
LegionVector<int> version_infos;
};
int &TaskOp::get_version_info() { __assert_fail(); }
const int &PointTask::get_version_info() const {
if (version_infos.size())
return version_infos[0];
return slice_owner->get_version_info();
}
```
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug tree-optimization/113757] [14 regression] ICE when building legion-23.03.0 since r14-8398
2024-02-04 20:29 [Bug c++/113757] New: [14 regression] ICE when building legion-23.03.0 sjames at gcc dot gnu.org
` (5 preceding siblings ...)
2024-02-05 3:28 ` sjames at gcc dot gnu.org
@ 2024-02-05 3:59 ` pinskia at gcc dot gnu.org
2024-02-05 16:53 ` jamborm at gcc dot gnu.org
` (5 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-02-05 3:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113757
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|needs-reduction |
--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Reduced a little further without the undefinedness but with a noreturn function
in use (which is important for the ICE here):
```
long size();
struct ll { virtual int hh(); };
ll *slice_owner;
int ll::hh() { __builtin_exit(0); }
int nn() {
if (size())
return 0;
return slice_owner->hh();
}
int (*a)() = nn;
```
Note the decl a is needed to force nn to have its address taken (simulating a
virtual function).
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug tree-optimization/113757] [14 regression] ICE when building legion-23.03.0 since r14-8398
2024-02-04 20:29 [Bug c++/113757] New: [14 regression] ICE when building legion-23.03.0 sjames at gcc dot gnu.org
` (6 preceding siblings ...)
2024-02-05 3:59 ` pinskia at gcc dot gnu.org
@ 2024-02-05 16:53 ` jamborm at gcc dot gnu.org
2024-02-08 10:18 ` jamborm at gcc dot gnu.org
` (4 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: jamborm at gcc dot gnu.org @ 2024-02-05 16:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113757
Martin Jambor <jamborm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |jamborm at gcc dot gnu.org
Status|NEW |ASSIGNED
--- Comment #7 from Martin Jambor <jamborm at gcc dot gnu.org> ---
This is a very particular interaction of the patch with speculative
devirtualization. Mine.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug tree-optimization/113757] [14 regression] ICE when building legion-23.03.0 since r14-8398
2024-02-04 20:29 [Bug c++/113757] New: [14 regression] ICE when building legion-23.03.0 sjames at gcc dot gnu.org
` (7 preceding siblings ...)
2024-02-05 16:53 ` jamborm at gcc dot gnu.org
@ 2024-02-08 10:18 ` jamborm at gcc dot gnu.org
2024-03-08 23:48 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: jamborm at gcc dot gnu.org @ 2024-02-08 10:18 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113757
--- Comment #8 from Martin Jambor <jamborm at gcc dot gnu.org> ---
I have proposed a fix on the mailing list:
https://inbox.sourceware.org/gcc-patches/ri6bk8r5kfi.fsf@virgil.suse.cz/T/#u
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug tree-optimization/113757] [14 regression] ICE when building legion-23.03.0 since r14-8398
2024-02-04 20:29 [Bug c++/113757] New: [14 regression] ICE when building legion-23.03.0 sjames at gcc dot gnu.org
` (8 preceding siblings ...)
2024-02-08 10:18 ` jamborm at gcc dot gnu.org
@ 2024-03-08 23:48 ` cvs-commit at gcc dot gnu.org
2024-03-08 23:50 ` jamborm at gcc dot gnu.org
` (2 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-03-08 23:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113757
--- Comment #9 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Jambor <jamborm@gcc.gnu.org>:
https://gcc.gnu.org/g:54e505d0446f86b7ad383acbb8e5501f20872b64
commit r14-9403-g54e505d0446f86b7ad383acbb8e5501f20872b64
Author: Martin Jambor <mjambor@suse.cz>
Date: Sat Mar 9 00:47:22 2024 +0100
ipa: Avoid excessive removing of SSAs (PR 113757)
PR 113757 shows that the code which was meant to debug-reset and
remove SSAs defined by LHSs of calls redirected to
__builtin_unreachable can trigger also when speculative
devirtualization creates a call to a noreturn function (and since it
is noreturn, it does not bother dealing with its return value).
What is more, it seems that the code handling this case is not really
necessary. I feel slightly idiotic about this because I have a
feeling that I added it because of a failing test-case but I can
neither find the testcase nor a reason why the code in
cgraph_edge::redirect_call_stmt_to_callee would not be sufficient (it
turns the SSA name into a default-def, a bit like IPA-SRA, but any
code dominated by a call to a noreturn is not dangerous when it comes
to its side-effects). So this patch just removes the handling.
gcc/ChangeLog:
2024-02-07 Martin Jambor <mjambor@suse.cz>
PR ipa/113757
* tree-inline.cc (redirect_all_calls): Remove code adding SSAs to
id->killed_new_ssa_names.
gcc/testsuite/ChangeLog:
2024-02-07 Martin Jambor <mjambor@suse.cz>
PR ipa/113757
* g++.dg/ipa/pr113757.C: New test.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug tree-optimization/113757] [14 regression] ICE when building legion-23.03.0 since r14-8398
2024-02-04 20:29 [Bug c++/113757] New: [14 regression] ICE when building legion-23.03.0 sjames at gcc dot gnu.org
` (9 preceding siblings ...)
2024-03-08 23:48 ` cvs-commit at gcc dot gnu.org
@ 2024-03-08 23:50 ` jamborm at gcc dot gnu.org
2024-04-08 15:51 ` cvs-commit at gcc dot gnu.org
2024-05-15 13:46 ` cvs-commit at gcc dot gnu.org
12 siblings, 0 replies; 14+ messages in thread
From: jamborm at gcc dot gnu.org @ 2024-03-08 23:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113757
Martin Jambor <jamborm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #10 from Martin Jambor <jamborm at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug tree-optimization/113757] [14 regression] ICE when building legion-23.03.0 since r14-8398
2024-02-04 20:29 [Bug c++/113757] New: [14 regression] ICE when building legion-23.03.0 sjames at gcc dot gnu.org
` (10 preceding siblings ...)
2024-03-08 23:50 ` jamborm at gcc dot gnu.org
@ 2024-04-08 15:51 ` cvs-commit at gcc dot gnu.org
2024-05-15 13:46 ` cvs-commit at gcc dot gnu.org
12 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-04-08 15:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113757
--- Comment #11 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Martin Jambor
<jamborm@gcc.gnu.org>:
https://gcc.gnu.org/g:40ddc0b05a47f999b24f20c1becb79004995731b
commit r13-8594-g40ddc0b05a47f999b24f20c1becb79004995731b
Author: Martin Jambor <mjambor@suse.cz>
Date: Mon Apr 8 17:34:33 2024 +0200
ipa: Self-DCE of uses of removed call LHSs (PR 108007)
PR 108007 is another manifestation where we rely on DCE to clean-up
after IPA-SRA and if the user explicitely switches DCE off, IPA-SRA
can leave behind statements which are fed uninitialized values and
trap, even though their results are themselves never used.
I have already fixed this for unused parameters in callees, this bug
shows that almost the same thing can happen for removed returns, on
the side of callers. This means that the issue has to be fixed
elsewhere, in call redirection. This patch adds a function which
looks for (and through, using a work-list) uses of operations fed
specific SSA names and removes them all.
That would have been easy if it wasn't for debug statements during
tree-inline (from which call redirection is also invoked). Debug
statements are decoupled from the rest at this point and iterating
over uses of SSAs does not bring them up. During tree-inline they are
handled especially at the end, I assume in order to make sure that
relative ordering of UIDs are the same with and without debug info.
This means that during tree-inline we need to make a hash of killed
SSAs, that we already have in copy_body_data, available to the
function making the purging. So the patch duly does also that, making
the interface slightly ugly. Moreover, all newly unused SSA names
need to be freed and as PR 112616 showed, it must be done in a defined
order, which is what newly added ipa_release_ssas_in_hash does.
This backport to gcc-13 also contains
54e505d0446f86b7ad383acbb8e5501f20872b64 in order not to reintroduce
PR 113757.
gcc/ChangeLog:
2024-04-05 Martin Jambor <mjambor@suse.cz>
PR ipa/108007
PR ipa/112616
* cgraph.h (cgraph_edge): Add a parameter to
redirect_call_stmt_to_callee.
* ipa-param-manipulation.h (ipa_param_adjustments): Add a
parameter to modify_call.
(ipa_release_ssas_in_hash): Declare.
* cgraph.cc (cgraph_edge::redirect_call_stmt_to_callee): New
parameter killed_ssas, pass it to padjs->modify_call.
* ipa-param-manipulation.cc (purge_all_uses): New function.
(ipa_param_adjustments::modify_call): New parameter killed_ssas.
Instead of substituting uses, invoke purge_all_uses. If
hash of killed SSAs has not been provided, create a temporary one
and release SSAs that have been added to it.
(compare_ssa_versions): New function.
(ipa_release_ssas_in_hash): Likewise.
* tree-inline.cc (redirect_all_calls): Create
id->killed_new_ssa_names earlier, pass it to edge redirection,
adjust a comment.
(copy_body): Release SSAs in id->killed_new_ssa_names.
gcc/testsuite/ChangeLog:
2024-01-15 Martin Jambor <mjambor@suse.cz>
PR ipa/108007
PR ipa/112616
* gcc.dg/ipa/pr108007.c: New test.
* gcc.dg/ipa/pr112616.c: Likewise.
(cherry picked from commit a9a8426e534760b8d3a250e9bd3cff4db131a2be)
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug tree-optimization/113757] [14 regression] ICE when building legion-23.03.0 since r14-8398
2024-02-04 20:29 [Bug c++/113757] New: [14 regression] ICE when building legion-23.03.0 sjames at gcc dot gnu.org
` (11 preceding siblings ...)
2024-04-08 15:51 ` cvs-commit at gcc dot gnu.org
@ 2024-05-15 13:46 ` cvs-commit at gcc dot gnu.org
12 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-05-15 13:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113757
--- Comment #12 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Martin Jambor
<jamborm@gcc.gnu.org>:
https://gcc.gnu.org/g:2183e5b5aa3a080624cb95a06993e34dedd09cb2
commit r12-10443-g2183e5b5aa3a080624cb95a06993e34dedd09cb2
Author: Martin Jambor <mjambor@suse.cz>
Date: Mon Apr 8 17:34:33 2024 +0200
ipa: Self-DCE of uses of removed call LHSs (PR 108007)
PR 108007 is another manifestation where we rely on DCE to clean-up
after IPA-SRA and if the user explicitely switches DCE off, IPA-SRA
can leave behind statements which are fed uninitialized values and
trap, even though their results are themselves never used.
I have already fixed this for unused parameters in callees, this bug
shows that almost the same thing can happen for removed returns, on
the side of callers. This means that the issue has to be fixed
elsewhere, in call redirection. This patch adds a function which
looks for (and through, using a work-list) uses of operations fed
specific SSA names and removes them all.
That would have been easy if it wasn't for debug statements during
tree-inline (from which call redirection is also invoked). Debug
statements are decoupled from the rest at this point and iterating
over uses of SSAs does not bring them up. During tree-inline they are
handled especially at the end, I assume in order to make sure that
relative ordering of UIDs are the same with and without debug info.
This means that during tree-inline we need to make a hash of killed
SSAs, that we already have in copy_body_data, available to the
function making the purging. So the patch duly does also that, making
the interface slightly ugly. Moreover, all newly unused SSA names
need to be freed and as PR 112616 showed, it must be done in a defined
order, which is what newly added ipa_release_ssas_in_hash does.
This backport to gcc-13 also contains
54e505d0446f86b7ad383acbb8e5501f20872b64 in order not to reintroduce
PR 113757.
gcc/ChangeLog:
2024-04-05 Martin Jambor <mjambor@suse.cz>
PR ipa/108007
PR ipa/112616
* cgraph.h (cgraph_edge): Add a parameter to
redirect_call_stmt_to_callee.
* ipa-param-manipulation.h (ipa_param_adjustments): Add a
parameter to modify_call.
(ipa_release_ssas_in_hash): Declare.
* cgraph.cc (cgraph_edge::redirect_call_stmt_to_callee): New
parameter killed_ssas, pass it to padjs->modify_call.
* ipa-param-manipulation.cc (purge_all_uses): New function.
(ipa_param_adjustments::modify_call): New parameter killed_ssas.
Instead of substituting uses, invoke purge_all_uses. If
hash of killed SSAs has not been provided, create a temporary one
and release SSAs that have been added to it.
(compare_ssa_versions): New function.
(ipa_release_ssas_in_hash): Likewise.
* tree-inline.cc (redirect_all_calls): Create
id->killed_new_ssa_names earlier, pass it to edge redirection,
adjust a comment.
(copy_body): Release SSAs in id->killed_new_ssa_names.
gcc/testsuite/ChangeLog:
2024-01-15 Martin Jambor <mjambor@suse.cz>
PR ipa/108007
PR ipa/112616
* gcc.dg/ipa/pr108007.c: New test.
* gcc.dg/ipa/pr112616.c: Likewise.
(cherry picked from commit 40ddc0b05a47f999b24f20c1becb79004995731b)
^ permalink raw reply [flat|nested] 14+ messages in thread