[Bug d/113758] New: d: Callee destructor call invalidates the live object, not the temporary

[Bug d/113758] New: d: Callee destructor call invalidates the live object, not the temporary

[ibuclaw at gdcproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113758

            Bug ID: 113758
           Summary: d: Callee destructor call invalidates the live object,
                    not the temporary
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: d
          Assignee: ibuclaw at gdcproject dot org
          Reporter: ibuclaw at gdcproject dot org
  Target Milestone: ---

D ABI does callee destruction of arguments, which depends on the argument
already being copied to a temporary before passing by ref.

At some point, the front-end stopped explicitly generating this temporary, so
now the code generator must take care of it.
---
struct Sdtor
{
    int field;
    ~this() { field = 0; }
}

void main()
{
    auto var = Sdtor(1);
    callee(var);
    assert(var.field == 1); // fails.
}

void callee(Sdtor param) { }

[Bug d/113758] d: Callee destructor call invalidates the live object, not the temporary

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113758

--- Comment #1 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:3c57b1c12a8e34d50bdf6aaf44146760db6d1b33

commit r14-8933-g3c57b1c12a8e34d50bdf6aaf44146760db6d1b33
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Sun Feb 4 22:04:14 2024 +0100

    d: Fix callee destructor call invalidates the live object [PR113758]

    When generating the argument, check the isCalleeDestroyingArgs hook, and
    force a TARGET_EXPR to be created if true, so that a reference to the
    live object isn't passed directly to the function that runs dtors.

    When instead dealing with caller running destructors, two temporaries
    were being generated, one explicit temporary generated by the D
    front-end, and another implicitly by the code generator.  This has been
    reduced to one by setting DECL_VALUE_EXPR on the explicit temporary to
    bind it to the implicit slot created for the TARGET_EXPR, as that has
    the shorter lifetime of the two.

            PR d/113758

    gcc/d/ChangeLog:

            * d-codegen.cc (d_build_call): Force a TARGET_EXPR when callee
            destorys its arguments.
            * decl.cc (DeclVisitor::visit (VarDeclaration *)): Set
            SET_DECL_VALUE_EXPR on the temporary variable to make it a
placeholder
            for the TARGET_EXPR_SLOT.

    gcc/testsuite/ChangeLog:

            * gdc.dg/torture/pr113758.d: New test.

[Bug d/113758] d: Callee destructor call invalidates the live object, not the temporary

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113758

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Iain Buclaw
<ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:e64fbf38e0b408696a97fbceb131ed1d19cbcd03

commit r13-8399-ge64fbf38e0b408696a97fbceb131ed1d19cbcd03
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Sun Feb 4 22:04:14 2024 +0100

    d: Fix callee destructor call invalidates the live object [PR113758]

    When generating the argument, check the isCalleeDestroyingArgs hook, and
    force a TARGET_EXPR to be created if true, so that a reference to the
    live object isn't passed directly to the function that runs dtors.

    When instead dealing with caller running destructors, two temporaries
    were being generated, one explicit temporary generated by the D
    front-end, and another implicitly by the code generator.  This has been
    reduced to one by setting DECL_VALUE_EXPR on the explicit temporary to
    bind it to the implicit slot created for the TARGET_EXPR, as that has
    the shorter lifetime of the two.

            PR d/113758

    gcc/d/ChangeLog:

            * d-codegen.cc (d_build_call): Force a TARGET_EXPR when callee
            destorys its arguments.
            * decl.cc (DeclVisitor::visit (VarDeclaration *)): Set
            SET_DECL_VALUE_EXPR on the temporary variable to make it a
placeholder
            for the TARGET_EXPR_SLOT.

    gcc/testsuite/ChangeLog:

            * gdc.dg/torture/pr113758.d: New test.

    (cherry picked from commit 3c57b1c12a8e34d50bdf6aaf44146760db6d1b33)

[Bug d/113758] d: Callee destructor call invalidates the live object, not the temporary

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113758

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Iain Buclaw
<ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:e276a94c061861a09dd790d206ec73d90478925e

commit r12-10189-ge276a94c061861a09dd790d206ec73d90478925e
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Sun Feb 4 22:04:14 2024 +0100

    d: Fix callee destructor call invalidates the live object [PR113758]

    When generating the argument, check the isCalleeDestroyingArgs hook, and
    force a TARGET_EXPR to be created if true, so that a reference to the
    live object isn't passed directly to the function that runs dtors.

    When instead dealing with caller running destructors, two temporaries
    were being generated, one explicit temporary generated by the D
    front-end, and another implicitly by the code generator.  This has been
    reduced to one by setting DECL_VALUE_EXPR on the explicit temporary to
    bind it to the implicit slot created for the TARGET_EXPR, as that has
    the shorter lifetime of the two.

            PR d/113758

    gcc/d/ChangeLog:

            * d-codegen.cc (d_build_call): Force a TARGET_EXPR when callee
            destorys its arguments.
            * decl.cc (DeclVisitor::visit (VarDeclaration *)): Set
            SET_DECL_VALUE_EXPR on the temporary variable to make it a
placeholder
            for the TARGET_EXPR_SLOT.

    gcc/testsuite/ChangeLog:

            * gdc.dg/torture/pr113758.d: New test.

    (cherry picked from commit 3c57b1c12a8e34d50bdf6aaf44146760db6d1b33)

[Bug d/113758] d: Callee destructor call invalidates the live object, not the temporary

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113758

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Iain Buclaw
<ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:8ceb48b1f8ebb9957d896082b0b503cf7f81cace

commit r11-11264-g8ceb48b1f8ebb9957d896082b0b503cf7f81cace
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Sun Feb 4 22:04:14 2024 +0100

    d: Fix callee destructor call invalidates the live object [PR113758]

    When generating the argument, check the isCalleeDestroyingArgs hook, and
    force a TARGET_EXPR to be created if true, so that a reference to the
    live object isn't passed directly to the function that runs dtors.

    When instead dealing with caller running destructors, two temporaries
    were being generated, one explicit temporary generated by the D
    front-end, and another implicitly by the code generator.  This has been
    reduced to one by setting DECL_VALUE_EXPR on the explicit temporary to
    bind it to the implicit slot created for the TARGET_EXPR, as that has
    the shorter lifetime of the two.

            PR d/113758

    gcc/d/ChangeLog:

            * d-codegen.cc (d_build_call): Force a TARGET_EXPR when callee
            destorys its arguments.
            * decl.cc (DeclVisitor::visit (VarDeclaration *)): Set
            SET_DECL_VALUE_EXPR on the temporary variable to make it a
placeholder
            for the TARGET_EXPR_SLOT.

    gcc/testsuite/ChangeLog:

            * gdc.dg/torture/pr113758.d: New test.

    (cherry picked from commit 3c57b1c12a8e34d50bdf6aaf44146760db6d1b33)

[Bug d/113758] d: Callee destructor call invalidates the live object, not the temporary

[ibuclaw at gdcproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113758

Iain Buclaw <ibuclaw at gdcproject dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #5 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
Fixed and backported.