From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 388AF3858C78; Thu,  8 Feb 2024 18:53:24 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 388AF3858C78
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1707418404;
	bh=HFnSQo7awc9Vj5ft60cGP/4PSbMAshIoPhJy9Rea9+o=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=s6stJnQNI8M1hgszWxvxnDE6gd4Kq6FtureV39ze9/Nh3/Zt0aYgl8s4S81kYsgcz
	 AbwvvBTY8n8OuPUo6wLsdlW6lAoAUTOYceVxH9++N3ht7BhzQi3lFRZY8FAogmtvcf
	 TBst+iKZiXy0B6PsqOMEdtQLLH55WJw+xq5BaoJs=
From: "anlauf at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/113799] gfc_replace_expr: double free detected ?
Date: Thu, 08 Feb 2024 18:53:23 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: anlauf at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cf_known_to_work
Message-ID: <bug-113799-4-6F6oJIZuN4@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-113799-4@http.gcc.gnu.org/bugzilla/>
References: <bug-113799-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113799

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |7.5.0, 8.5.0, 9.5.0

--- Comment #6 from anlauf at gcc dot gnu.org ---
It appears that we have an inconsistency in the handling of arithmetic
errors during simplification.

check_result has:

  if (val =3D=3D ARITH_OK || val =3D=3D ARITH_OVERFLOW)
    *rp =3D r;
  else
    gfc_free_expr (r);


while reduce_unary has:

  for (c =3D gfc_constructor_first (head); c; c =3D gfc_constructor_next (c=
))
    {
      rc =3D reduce_unary (eval, c->expr, &r);

      if (rc !=3D ARITH_OK)
        break;

      gfc_replace_expr (c->expr, r);
    }

With -fno-range-check, ARITH_OVERFLOW does not appear.=