public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/113808] [14 Regression] FAIL: libgomp.fortran/non-rectangular-loop-1.f90 since r14-8768 Date: Thu, 08 Feb 2024 10:44:05 +0000 [thread overview] Message-ID: <bug-113808-4-h83xvzlDfr@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-113808-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113808 --- Comment #10 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>: https://gcc.gnu.org/g:3f69db1812106cb5bab203e17a60300ac51cdc68 commit r14-8880-g3f69db1812106cb5bab203e17a60300ac51cdc68 Author: Tamar Christina <tamar.christina@arm.com> Date: Thu Feb 8 10:43:13 2024 +0000 middle-end: don't cache restart_loop in vectorizable_live_operations [PR113808] There's a bug in vectorizable_live_operation that restart_loop is defined outside the loop. This variable is supposed to indicate whether we are doing a first or last index reduction. The problem is that by defining it outside the loop it becomes dependent on the order we visit the USE/DEFs. In the given example, the loop isn't PEELED, but we visit the early exit uses first. This then sets the boolean to true and it can't get to false again. So when we visit the main exit we still treat it as an early exit for that SSA name. This cleans it up and renames the variables to something that's hopefully clearer to their intention. gcc/ChangeLog: PR tree-optimization/113808 * tree-vect-loop.cc (vectorizable_live_operation): Don't cache the value cross iterations. gcc/testsuite/ChangeLog: PR tree-optimization/113808 * gfortran.dg/vect/vect-early-break_1-PR113808.f90: New test.
next prev parent reply other threads:[~2024-02-08 10:44 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-07 12:47 [Bug tree-optimization/113808] New: [14 Regression] FAIL: libgomp.fortran/non-rectangular-loop-1.f90 rguenth at gcc dot gnu.org 2024-02-07 13:28 ` [Bug tree-optimization/113808] " rguenth at gcc dot gnu.org 2024-02-07 13:37 ` tnfchris at gcc dot gnu.org 2024-02-07 13:39 ` [Bug tree-optimization/113808] [14 Regression] FAIL: libgomp.fortran/non-rectangular-loop-1.f90 since r14-8768 jakub at gcc dot gnu.org 2024-02-07 13:48 ` rguenth at gcc dot gnu.org 2024-02-07 13:53 ` rguenth at gcc dot gnu.org 2024-02-07 14:09 ` rguenth at gcc dot gnu.org 2024-02-07 14:20 ` jakub at gcc dot gnu.org 2024-02-07 14:20 ` jakub at gcc dot gnu.org 2024-02-07 14:25 ` rguenth at gcc dot gnu.org 2024-02-08 4:28 ` tnfchris at gcc dot gnu.org 2024-02-08 10:44 ` cvs-commit at gcc dot gnu.org [this message] 2024-02-08 10:45 ` tnfchris at gcc dot gnu.org 2024-02-08 11:11 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-113808-4-h83xvzlDfr@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).