From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 08A29385841F; Thu,  8 Feb 2024 10:44:06 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 08A29385841F
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1707389047;
	bh=G2Tyu0Ep7m3gP0O6uYhYj1ubN7hgJFkqwChYkNAv2EY=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=sFje8i3p2kTGFnZgOZYpf8wXaHItMua6T3O7DB2XhlYnwGh6KSr8qtXZba1fio1C4
	 votH/yDfjq84K/2XMn2YKLNCdu1qZA00YbOefQRSlnnO9GFjNQVeRJMnAKtIH2wJKq
	 D/ojfnSuy0EjCoFErj5dm7XgQKXUAaJNPjU7IfIo=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/113808] [14 Regression] FAIL:
 libgomp.fortran/non-rectangular-loop-1.f90 since r14-8768
Date: Thu, 08 Feb 2024 10:44:05 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: tnfchris at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-113808-4-h83xvzlDfr@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-113808-4@http.gcc.gnu.org/bugzilla/>
References: <bug-113808-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113808

--- Comment #10 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org=
>:

https://gcc.gnu.org/g:3f69db1812106cb5bab203e17a60300ac51cdc68

commit r14-8880-g3f69db1812106cb5bab203e17a60300ac51cdc68
Author: Tamar Christina <tamar.christina@arm.com>
Date:   Thu Feb 8 10:43:13 2024 +0000

    middle-end: don't cache restart_loop in vectorizable_live_operations
[PR113808]

    There's a bug in vectorizable_live_operation that restart_loop is defin=
ed
    outside the loop.

    This variable is supposed to indicate whether we are doing a first or l=
ast
    index reduction.  The problem is that by defining it outside the loop it
becomes
    dependent on the order we visit the USE/DEFs.

    In the given example, the loop isn't PEELED, but we visit the early exit
uses
    first.  This then sets the boolean to true and it can't get to false ag=
ain.

    So when we visit the main exit we still treat it as an early exit for t=
hat
    SSA name.

    This cleans it up and renames the variables to something that's hopeful=
ly
    clearer to their intention.

    gcc/ChangeLog:

            PR tree-optimization/113808
            * tree-vect-loop.cc (vectorizable_live_operation): Don't cache =
the
            value cross iterations.

    gcc/testsuite/ChangeLog:

            PR tree-optimization/113808
            * gfortran.dg/vect/vect-early-break_1-PR113808.f90: New test.=