public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rdapp at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/113827] New: MrBayes benchmark redundant load
Date: Thu, 08 Feb 2024 11:38:17 +0000	[thread overview]
Message-ID: <bug-113827-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113827

            Bug ID: 113827
           Summary: MrBayes benchmark redundant load
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rdapp at gcc dot gnu.org
                CC: juzhe.zhong at rivai dot ai, law at gcc dot gnu.org,
                    pan2.li at intel dot com
            Blocks: 79704
  Target Milestone: ---
            Target: riscv

A hot block in the MrBayes benchmark (as used in the Phoronix testsuite) has a
redundant scalar load when vectorized.

Minimal example, compiled with -march=rv64gcv -O3

int foo (float **a, float f, int n)
{
  for (int i = 0; i < n; i++)
    {
      a[i][0] /= f;
      a[i][1] /= f;
      a[i][2] /= f;
      a[i][3] /= f;
      a[i] += 4;
    }
}

GCC:
.L3:
        ld      a5,0(a0)
        vle32.v v1,0(a5)
        vfmul.vv        v1,v1,v2
        vse32.v v1,0(a5)
        addi    a5,a5,16
        sd      a5,0(a0)
        addi    a0,a0,8
        bne     a0,a4,.L3

The value of a5 doesn't change after the store to 0(a0).

LLVM:
.L3
        vle32.v   v8,(a1)
        addi      a3,a1,16
        sd        a3,0(a2)
        vfdiv.vf  v8,v8,fa5
        addi      a2,a2,8
        vse32.v   v8,(a1)
        bne       a2,a0,.L3


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79704
[Bug 79704] [meta-bug] Phoronix Test Suite compiler performance issues

             reply	other threads:[~2024-02-08 11:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-08 11:38 rdapp at gcc dot gnu.org [this message]
2024-02-08 14:29 ` [Bug target/113827] MrBayes benchmark redundant load on riscv rdapp at gcc dot gnu.org
2024-02-09  4:28 ` [Bug target/113827] MrBayes benchmark redundant load pinskia at gcc dot gnu.org
2024-02-09  5:10 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113827-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).