public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "sandra at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/113904] [OpenMP][5.0][5.1] Dynamic context selector 'user={condition(expr)}' not handled Date: Tue, 14 May 2024 00:44:32 +0000 [thread overview] Message-ID: <bug-113904-4-KZxRk4Vu0K@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-113904-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113904 --- Comment #7 from sandra at gcc dot gnu.org --- My most recent metadirectives/dynamic selector patch set does include partial support for dynamic selectors. For C/C++ it handles expressions that reference variables/functions that are globally visible, and for C++ also class fields/methods, references to the "this" pointer, etc, but it gives a "sorry" for references to parameters on the base function declaration. For Fortran it still permits only constant expressions in selectors. https://gcc.gnu.org/pipermail/gcc-patches/2024-May/650725.html I agree with Tobias's comment 3 that the right solution is to wrap these expressions in a function that has the same parameters as the associated base decl, and that these generated functions can be internal and inline. But, it might be more efficient to bypass actually creating functions and instead just stash a parameter map (e.g. to match parameter positions to decls) along with the expression so that the gimplifier can effectively do the inlining at the point where it synthesizes both the replacement call and the code to match dynamic selectors (in posted patch set above).
prev parent reply other threads:[~2024-05-14 0:44 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-13 11:26 [Bug middle-end/113904] New: " burnus at gcc dot gnu.org 2024-02-13 17:32 ` [Bug middle-end/113904] " burnus at gcc dot gnu.org 2024-02-13 19:56 ` cvs-commit at gcc dot gnu.org 2024-02-13 20:29 ` burnus at gcc dot gnu.org 2024-02-13 21:06 ` sandra at gcc dot gnu.org 2024-04-11 4:51 ` sandra at gcc dot gnu.org 2024-04-12 3:00 ` sandra at gcc dot gnu.org 2024-05-14 0:44 ` sandra at gcc dot gnu.org [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-113904-4-KZxRk4Vu0K@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).