From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 942953857C77; Wed, 13 Mar 2024 15:21:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 942953857C77 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1710343297; bh=vO6PBlVehem2AXuT0MtklcCd1DbFE8faDi6DYS7vhYA=; h=From:To:Subject:Date:In-Reply-To:References:From; b=KyulompANNkX8TouxKwe1shYibxcQViZRF2a/6DHYUUuNU9f43LkZ2oY6eXcWUjc+ EUxxsGTXf++krj5flQ49lGfoSwT8Sb2ZA7nES2RqLK2w9ZPLimHmvEjHfvL86WMxju FJBLkgL/plQPC4dEtQmpeVBai6cAKbU7DPgAR4M0= From: "hubicka at ucw dot cz" To: gcc-bugs@gcc.gnu.org Subject: [Bug ipa/113907] [11/12/13/14 regression] ICU miscompiled since on x86 since r14-5109-ga291237b628f41 Date: Wed, 13 Mar 2024 15:21:37 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: ipa X-Bugzilla-Version: 14.0 X-Bugzilla-Keywords: wrong-code X-Bugzilla-Severity: normal X-Bugzilla-Who: hubicka at ucw dot cz X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: hubicka at gcc dot gnu.org X-Bugzilla-Target-Milestone: 14.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113907 --- Comment #57 from Jan Hubicka --- > So, we can punt on differences there (that is desirable for backporting a= nd > maybe GCC 14 too), or we could at that point populate an int vector, whic= h maps Yep, that is what I do. I had bug in that so I am re-running (forgot to check that callers and callee argument count matches and this cuases ICE during LLVM LTO link). It seems these extra checks makes no difference in practice.=20 During bootstrap there are no pairs of functions during bootstrap where we new checks punt on value range difference or jump function difference that would be merged otherwise. Most common case where we could merge but we don't are those triggered by TBAA. > the callee > vector indexes to indexes in the callee vector in the other candidate fun= ction. > If unsuccessful, we just free the vector, if successful, we first walk al= l the > callees and union stuff in there using that vector. This is the plan for metadata merging. A small complication here is that ICF works by comparing bodies to a leader of equivalence class but this leader is not necessarilly the surviving function body. So if we compared A to L (leader) and B to L and then decided replace A by B, we need to be able to combine the permutations so we know how to map call sites in A to ones in B. The same is true about SSA names and basic blocks. I have patch for that for next stage1.=