From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 101993858C56; Wed, 20 Mar 2024 18:33:07 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 101993858C56
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1710959588;
	bh=KaGjzQQceqeV+HxjxEkA8GjzdhsiT/bZfDPg9r3SMxI=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=YdhQqwiV4+onH5BB1lY/rqb65nn1C6EzOgn5J0tAflUUnV1VH1oYTbXkS5n/3mz94
	 UXhfu8JgSvNGwJToT/tiL8Oyq3Rs1f4Lm76P3Qde/iYJ4E9rh7m+FY2qdgEDZJ/XBh
	 iUzeMcU/aS/qWXkvURGP/nNIXW7CU4Ns2c/+2o2Q=
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/113907] [11/12/13/14 regression] ICU miscompiled since on
 x86 since r14-5109-ga291237b628f41
Date: Wed, 20 Mar 2024 18:33:07 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: hubicka at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-113907-4-bQnJ6FzUYm@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-113907-4@http.gcc.gnu.org/bugzilla/>
References: <bug-113907-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113907

--- Comment #67 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Martin Jambor from comment #66)
> Created attachment 57750 [details]
> Patch comparing jump functions
>=20
> I'm testing this patch.  (Not sure how to best check that it does not
> inadvertently pessimize ICF too much, except for ICF testcases.)

Bet modify the patch slightly (for testing only), so instead of those 3
return_false_with_msg it would just set some flag somewhere that the pair is
not ICF optimizable, then after the early return false in sem_function::mer=
ge
check that flag
and log into some /tmp/ file using appending if the ICF merge would be done=
 and
the flag wasn't set, or if the ICF merge wouldn't be done (and in that case
return false too), bootstrap/regtest with such patch, plus build a few other
packages (firefox, libreoffice) and then get statistics from the log file on
what percentage of ICF folding it now prevents.=