From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id D0A093858D28; Mon,  8 Apr 2024 16:56:58 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D0A093858D28
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1712595418;
	bh=H1vF/rgnJmNI21v4WlYYZQvzAtq+Vi2nsFVc1IIJixs=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=mCaU8YYmmMym8zgFTqptE5blcMfvqG4gakL+vaMIDPPejYg8gC/E7GcySn9JoQ37f
	 B+V9KmqPo8mx4r3UAJus+7KsS+MkJejM9X5cJyr2TbwBOZHrQ8bRF+qpvfZS48nF1T
	 wSX3HBYlusWpMpEudWdCRWxZBetyy9Pn/SqplmIs=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/113907] [11/12/13/14 regression] ICU miscompiled on x86
 since r14-5109-ga291237b628f41
Date: Mon, 08 Apr 2024 16:56:57 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: hubicka at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-113907-4-yLeUCGxoEh@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-113907-4@http.gcc.gnu.org/bugzilla/>
References: <bug-113907-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113907

--- Comment #74 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Jambor <jamborm@gcc.gnu.org>:

https://gcc.gnu.org/g:1162861439fd3c4b30fc3ccd49462e47e876f04a

commit r14-9840-g1162861439fd3c4b30fc3ccd49462e47e876f04a
Author: Martin Jambor <mjambor@suse.cz>
Date:   Mon Apr 8 18:53:23 2024 +0200

    ipa: Compare jump functions in ICF (PR 113907)

    In PR 113907 comment #58, Honza found a case where ICF thinks bodies
    of functions are equivalent but becaise of difference in aliases in a
    memory access, different aggregate jump functions are associated with
    supposedly equivalent call statements.  This patch adds a way to
    compare jump functions and plugs it into ICF to avoid the issue.

    gcc/ChangeLog:

    2024-03-20  Martin Jambor  <mjambor@suse.cz>

            PR ipa/113907
            * ipa-prop.h (class ipa_vr): Declare new overload of a member
function
            equal_p.
            (ipa_jump_functions_equivalent_p): Declare.
            * ipa-prop.cc (ipa_vr::equal_p): New function.
            (ipa_agg_pass_through_jf_equivalent_p): Likewise.
            (ipa_agg_jump_functions_equivalent_p): Likewise.
            (ipa_jump_functions_equivalent_p): Likewise.
            * ipa-cp.h (values_equal_for_ipcp_p): Declare.
            * ipa-cp.cc (values_equal_for_ipcp_p): Make function public.
            * ipa-icf-gimple.cc: Include alloc-pool.h, symbol-summary.h,
sreal.h,
            ipa-cp.h and ipa-prop.h.
            (func_checker::compare_gimple_call): Comapre jump functions.

    gcc/testsuite/ChangeLog:

    2024-03-20  Martin Jambor  <mjambor@suse.cz>

            PR ipa/113907
            * gcc.dg/lto/pr113907_0.c: New.
            * gcc.dg/lto/pr113907_1.c: Likewise.
            * gcc.dg/lto/pr113907_2.c: Likewise.=