From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 638E83857C5B; Tue, 13 Feb 2024 20:33:58 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 638E83857C5B
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1707856438;
	bh=8hcdeRTDlnMx8LXTKraLpommqwgCKn+xAR6ZYhPKWRI=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=srcLjOspeFNC43oSIwZ+bM4/Ybm5dpE16rL0//p4rzCwvWbunDuCM0WJ8ZQBm805z
	 +KfTEtrMtiQG/qFRCInbhyb671W8tHoLTe0SVUs1ffJBAU/8NXpEOqPx4shP1TE7zI
	 NcMSN4N9YBTCQdu2BjSMX2kRZSM2krxnO0ETlq5M=
From: "anlauf at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/113911] [14 Regression] Length is lost passing
 deferred-length character to subroutine
Date: Tue, 13 Feb 2024 20:33:58 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: anlauf at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-113911-4-n7Al784JRZ@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-113911-4@http.gcc.gnu.org/bugzilla/>
References: <bug-113911-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113911

--- Comment #4 from anlauf at gcc dot gnu.org ---
Running f951 on the testcase under valgrind shows (among others) a
frontend memleak in gfc_resolve_substring_charlen, obviously fixed by

diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc
index 44f89f6afb4..b1f36efb10b 100644
--- a/gcc/fortran/resolve.cc
+++ b/gcc/fortran/resolve.cc
@@ -5392,11 +5392,7 @@ gfc_resolve_substring_charlen (gfc_expr *e)
     end =3D NULL;

   if (!start || !end)
-    {
-      gfc_free_expr (start);
-      gfc_free_expr (end);
-      return;
-    }
+    goto cleanup;

   /* Length =3D (end - start + 1).
      Check first whether it has a constant length.  */
@@ -5431,6 +5427,10 @@ gfc_resolve_substring_charlen (gfc_expr *e)
   /* Make sure that the length is simplified.  */
   gfc_simplify_expr (e->ts.u.cl->length, 1);
   gfc_resolve_expr (e->ts.u.cl->length);
+
+cleanup:
+  gfc_free_expr (start);
+  gfc_free_expr (end);
 }=