From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id A24F93857432; Wed, 14 Feb 2024 07:26:32 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A24F93857432
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1707895592;
	bh=jGLdlpOar9htyPMxHL5/l72xgUy0i9+nGfKMMYCAHAA=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=GWkQStx+mu9BvDAlqMkSwrkNkNPep8puN0QrlJY1D3yMtube9SWlFI/X+eT7t2ckJ
	 oNL9sw26HcCWaeHYoyPBXQkC78D5WDFU7IVUTBE9rYKcqfxLP2pcxrux9rz1S6J3GC
	 NXjP9cWD04hoj7dj9QxcQKwcIlAufSrXIufMP0to=
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/113915] [14 regression] glibc's _dl_find_object_update_1
  miscompiled for armv7a since r14-4365-g0731889c026bfe
Date: Wed, 14 Feb 2024 07:26:32 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: blocker
X-Bugzilla-Who: pinskia at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-113915-4-Tsl6ZxWeYj@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-113915-4@http.gcc.gnu.org/bugzilla/>
References: <bug-113915-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113915

--- Comment #9 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #8)
> (In reply to Andrew Pinski from comment #7)
> > cannot be conditional executed.
>=20
> That is because most of the insn patterns in sync.md don't have=20
>   [(set_attr "conds" "nocond")])
>=20
> on them ....
>=20
> Someone will have to submit that patch after testing, I don't have the
> bandwidth to do it though.

Actually wait that is the not fix.

This should work, I think:
```
diff --git a/gcc/config/arm/arm.cc b/gcc/config/arm/arm.cc
index c44047c377a..d55ea59a727 100644
--- a/gcc/config/arm/arm.cc
+++ b/gcc/config/arm/arm.cc
@@ -25611,11 +25611,12 @@ arm_final_prescan_insn (rtx_insn *insn)

            case INSN:
              /* Instructions using or affecting the condition codes make it
-                fail.  */
+                fail or ones which cannot be predicable.  */
              scanbody =3D PATTERN (this_insn);
              if (!(GET_CODE (scanbody) =3D=3D SET
                    || GET_CODE (scanbody) =3D=3D PARALLEL)
-                 || get_attr_conds (this_insn) !=3D CONDS_NOCOND)
+                 || get_attr_conds (this_insn) !=3D CONDS_NOCOND
+                 || get_attr_predicable (this_insn) !=3D PREDICABLE_YES)
                fail =3D TRUE;
              break;

```=