From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 52FE53857C4B; Wed, 6 Mar 2024 17:42:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 52FE53857C4B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1709746943; bh=pOdwUSKUWkhe33rGIXGDczY7ymO73eapk58VgBwEUpQ=; h=From:To:Subject:Date:In-Reply-To:References:From; b=uapZ97+WPn4wfpDS4R3pz+4Wk3jOBhZOpRu1AoAEficqT0Qr5pQcZjzLwJjswJQoQ OBlH4bLsaXGPkeYMvM2bxIOMUoVCFCrDWixrM6u583TOywazsXJDYm14Cev8AL0ENj 1ZpUuEznHaaO4mPjZ8dvtcwQyKBZBHNU51jI0fI4= From: "cvs-commit at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/113915] [14 regression] glibc's _dl_find_object_update_1 miscompiled for armv7a since r14-4365-g0731889c026bfe Date: Wed, 06 Mar 2024 17:42:21 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Version: 14.0 X-Bugzilla-Keywords: wrong-code X-Bugzilla-Severity: blocker X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: wilco at gcc dot gnu.org X-Bugzilla-Target-Milestone: 14.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113915 --- Comment #14 from GCC Commits --- The master branch has been updated by Wilco Dijkstra : https://gcc.gnu.org/g:b575f37a342cebb954aa85fa45df0604bfa1ada9 commit r14-9343-gb575f37a342cebb954aa85fa45df0604bfa1ada9 Author: Wilco Dijkstra Date: Wed Mar 6 17:35:16 2024 +0000 ARM: Fix conditional execution [PR113915] By default most patterns can be conditionalized on Arm targets. However Thumb-2 predication requires the "predicable" attribute be explicitly set to "yes". Most patterns are shared between Arm and Thumb(-2) and a= re marked with "predicable". Given this sharing, it does not make sense to use a different default for Arm. So only consider conditional execution of instructions that have the predicable attribute set to yes. This ensures that patterns not explicitly marked as such are never conditionally executed. gcc/ChangeLog: PR target/113915 * config/arm/arm.md (NOCOND): Improve comment. (arm_rev*) Add predicable. * config/arm/arm.cc (arm_final_prescan_insn): Add check for PREDICABLE_YES. gcc/testsuite/ChangeLog: PR target/113915 * gcc.target/arm/builtin-bswap-1.c: Fix test to allow condition= al execution both for Arm and Thumb-2.=