[Bug fortran/113956] [13/14 Regression] ice in gfc_trans_pointer_assignment, at fortran/trans-expr.cc:10524

["anlauf at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113956

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.3
                 CC|                            |anlauf at gcc dot gnu.org,
                   |                            |pault at gcc dot gnu.org
           Keywords|                            |ice-on-valid-code
   Last reconfirmed|                            |2024-03-29
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
            Summary|[14 Regression] ice in      |[13/14 Regression] ice in
                   |gfc_trans_pointer_assignmen |gfc_trans_pointer_assignmen
                   |t, at                       |t, at
                   |fortran/trans-expr.cc:10524 |fortran/trans-expr.cc:10524

--- Comment #2 from anlauf at gcc dot gnu.org ---
Reduced testcase:

subroutine test_array_char(p, x)
  character(*), target  :: x(100)
  character(:), pointer :: p(:)
  p => x
end subroutine


We hit an assert that can be worked around with the following patch:

diff --git a/gcc/fortran/trans-expr.cc b/gcc/fortran/trans-expr.cc
index d21e3956d6e..fa31f950363 100644
--- a/gcc/fortran/trans-expr.cc
+++ b/gcc/fortran/trans-expr.cc
@@ -10534,12 +10535,9 @@ gfc_trans_pointer_assignment (gfc_expr * expr1,
gfc_expr * expr2)
        {
          gfc_symbol *psym = expr1->symtree->n.sym;
          tmp = NULL_TREE;
-         if (psym->ts.type == BT_CHARACTER)
-           {
-             gcc_assert (psym->ts.u.cl->backend_decl
-                         && VAR_P (psym->ts.u.cl->backend_decl));
-             tmp = psym->ts.u.cl->backend_decl;
-           }
+         if (psym->ts.type == BT_CHARACTER
+             && psym->ts.u.cl->backend_decl)
+           tmp = psym->ts.u.cl->backend_decl;
          else if (expr1->ts.u.cl->backend_decl
                   && VAR_P (expr1->ts.u.cl->backend_decl))
            tmp = expr1->ts.u.cl->backend_decl;


This fragment was touched by Paul's fix for pr67740 (r14-4583), so adding
him.

@Paul: can you please have a look?