[Bug other/113961] New: [14 regression] 26_numerics/random/pr60037-neg.cc fails in new place after r14-9028-g7f3d900684ad98

[Bug other/113961] New: [14 regression] 26_numerics/random/pr60037-neg.cc fails in new place after r14-9028-g7f3d900684ad98

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113961

            Bug ID: 113961
           Summary: [14 regression] 26_numerics/random/pr60037-neg.cc
                    fails in new place after r14-9028-g7f3d900684ad98
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:7f3d900684ad989164114f25eb46a33871c6533d, r14-9028-g7f3d900684ad98
make  -k check RUNTESTFLAGS="conformance.exp=26_numerics/random/pr60037-neg.cc"
FAIL: 26_numerics/random/pr60037-neg.cc  -std=gnu++17  (test for errors, line
3350)
FAIL: 26_numerics/random/pr60037-neg.cc  -std=gnu++17 (test for excess errors)


commit 7f3d900684ad989164114f25eb46a33871c6533d (HEAD)
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Feb 7 11:31:10 2024 +0000

    libstdc++: Fix FAIL: 26_numerics/random/pr60037-neg.cc [PR113931]


This commit fixed the previous error in pr60037-neg.cc but caused a new one.

In file included from
/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/include/random:48,^M
                 from
/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/include/powerpc64le-unknown-linux-gnu/bits/stdc++.h:179,^M
                 from <command-line>:^M
/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/include/bits/random.h:
In instantiation of 'struct
std::__detail::_Adaptor<std::mersenne_twister_engine<long unsigned int, 32,
624, 397, 31, 2567483615, 11, 4294967295, 7, 2636928640, 15, 4022730752, 18,
1812433253>, long unsigned int>':^M
/home/seurer/gcc/git/gcc-test/libstdc++-v3/testsuite/26_numerics/random/pr60037-neg.cc:8:
  required from here^M
/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/include/bits/random.h:270:
error: static assertion failed: template argument must be a floating point
type^M
/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/include/bits/random.h:270:
note: 'std::integral_constant<bool, false>::value' evaluates to false^M
In file included from
/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/include/random:50:^M
/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/include/bits/random.tcc:
In instantiation of '_RealType
std::generate_canonical(_UniformRandomNumberGenerator&) [with _RealType = long
unsigned int; long unsigned int __bits = 64; _UniformRandomNumberGenerator =
mersenne_twister_engine<long unsigned int, 32, 624, 397, 31, 2567483615, 11,
4294967295, 7, 2636928640, 15, 4022730752, 18, 1812433253>]':^M
/home/seurer/gcc/git/gcc-test/libstdc++-v3/testsuite/26_numerics/random/pr60037-neg.cc:11:
  required from here^M
/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/include/bits/random.tcc:3351:
error: static assertion failed: template argument must be a floating point
type^M
/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/include/bits/random.tcc:3351:
note: 'std::integral_constant<bool, false>::value' evaluates to false^M
compiler exited with status 1
PASS: 26_numerics/random/pr60037-neg.cc  -std=gnu++17  (test for errors, line
270)
FAIL: 26_numerics/random/pr60037-neg.cc  -std=gnu++17  (test for errors, line
3350)

[Bug other/113961] [14 regression] 26_numerics/random/pr60037-neg.cc fails in new place after r14-9028-g7f3d900684ad98

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113961

--- Comment #1 from seurer at gcc dot gnu.org ---
 < previous run: g:1aef0a9b07766d100a218ef3e9576d0a0dd35a2d,
r14-9027-g1aef0a9b07766d
 > this run    : g:7f3d900684ad989164114f25eb46a33871c6533d,
r14-9028-g7f3d900684ad98

 < FAIL: 26_numerics/random/pr60037-neg.cc  -std=gnu++17  (test for errors,
line 271)
 > FAIL: 26_numerics/random/pr60037-neg.cc  -std=gnu++17  (test for errors,
line 3350)

[Bug other/113961] [14 regression] 26_numerics/random/pr60037-neg.cc fails in new place after r14-9028-g7f3d900684ad98

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113961

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
   Target Milestone|---                         |14.0
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2024-02-16

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Gah, now I see what's going on ... I have another patch for bits/random.h in my
local tree which is affecting those line numbers.

[Bug other/113961] [14 regression] 26_numerics/random/pr60037-neg.cc fails in new place after r14-9028-g7f3d900684ad98

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113961

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:c74131e77f1a6b7afe700d3526a8992dc9744b0c

commit r14-9038-gc74131e77f1a6b7afe700d3526a8992dc9744b0c
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Feb 7 11:31:10 2024 +0000

    libstdc++: Fix FAIL: 26_numerics/random/pr60037-neg.cc again [PR113961]

            PR libstdc++/87744
            PR libstdc++/113961

    libstdc++-v3/ChangeLog:

            * testsuite/26_numerics/random/pr60037-neg.cc: Adjust dg-error
            line number.

[Bug other/113961] [14 regression] 26_numerics/random/pr60037-neg.cc fails in new place after r14-9028-g7f3d900684ad98

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113961

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I think I got it right this time!

[Bug other/113961] [14 regression] 26_numerics/random/pr60037-neg.cc fails in new place after r14-9028-g7f3d900684ad98

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113961

--- Comment #5 from seurer at gcc dot gnu.org ---
Indeed you did, thanks!