public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/113970] [14 Regression] pch/system-{1,2}.C fails on darwin after r14-8987-gdd9d14f7d53 Date: Wed, 28 Feb 2024 00:26:14 +0000 [thread overview] Message-ID: <bug-113970-4-RdVJiIAzUn@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-113970-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113970 --- Comment #5 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Nathaniel Shead <nshead@gcc.gnu.org>: https://gcc.gnu.org/g:615b62aada6cc42759e5c43e196dab6c524925d6 commit r14-9201-g615b62aada6cc42759e5c43e196dab6c524925d6 Author: Nathaniel Shead <nathanieloshead@gmail.com> Date: Wed Feb 28 11:20:53 2024 +1100 c++: Revert deferring emission of inline variables [PR114013] This is a (partial) reversion of r14-8987-gdd9d14f7d53 to return to eagerly emitting inline variables to the middle-end when they are declared. 'import_export_decl' will still continue to accept them, as allowing this is a pure extension and doesn't seem to cause issues with modules, but otherwise deferring the emission of inline variables appears to cause issues on some targets and prevents some code using inline variable templates from correctly linking. There might be a more targetted way to support this, but due to the complexity of handling linkage and emission I'd prefer to wait till GCC 15 to explore our options. PR c++/113970 PR c++/114013 gcc/cp/ChangeLog: * decl.cc (make_rtl_for_nonlocal_decl): Don't defer inline variables. gcc/testsuite/ChangeLog: * g++.dg/cpp1z/inline-var10.C: New test. Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>
next prev parent reply other threads:[~2024-02-28 0:26 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-17 13:40 [Bug pch/113970] New: [14 Regression] pch/system-{1,2}.C fails on darwin iains at gcc dot gnu.org 2024-02-17 13:40 ` [Bug pch/113970] " iains at gcc dot gnu.org 2024-02-17 20:12 ` [Bug c++/113970] [14 Regression] pch/system-{1,2}.C fails on darwin after r14-8987-gdd9d14f7d53 iains at gcc dot gnu.org 2024-02-17 22:16 ` pinskia at gcc dot gnu.org 2024-02-22 16:12 ` iains at gcc dot gnu.org 2024-02-22 16:14 ` iains at gcc dot gnu.org 2024-02-28 0:26 ` cvs-commit at gcc dot gnu.org [this message] 2024-03-06 20:23 ` mpolacek at gcc dot gnu.org 2024-03-06 20:25 ` iains at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-113970-4-RdVJiIAzUn@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).