From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 3A5503858417; Wed, 21 Feb 2024 11:13:00 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3A5503858417
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1708513980;
	bh=q7mX0DjXPC6Sv+qsk2EXIXBMVHJvBXBJV4hNjeKsBLE=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=llWLuqnY8x3BE67jNAp0tY04cJ4zEZixso3wedp7CjrPtY1KydBGgdD6gftSA5pou
	 MU6jyLB+3ES5UsOzoj9JYWejrHPNqmEAAkNpD+TgbjJTqq+YUUVqupayoVc8Wv+rWw
	 8xyELGT4cT70WY8PcpfwbrIT2jhBrTccpruwA/MA=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/113995] ICE: in change_address_1, at emit-rtl.cc:2299
 with [[arm::streaming_compatible]] and -march=armv9-a+sve
 -finstrument-functions -fstack-clash-protection
Date: Wed, 21 Feb 2024 11:12:59 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: rsandifo at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-113995-4-1trXhWAmCB@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-113995-4@http.gcc.gnu.org/bugzilla/>
References: <bug-113995-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113995

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Richard Sandiford <rsandifo@gcc.gnu.or=
g>:

https://gcc.gnu.org/g:ad4df8cd080c9be738f61b5e91cc70a594c4419d

commit r14-9098-gad4df8cd080c9be738f61b5e91cc70a594c4419d
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Wed Feb 21 11:12:27 2024 +0000

    aarch64: Stack-clash prologues and VG saves [PR113995]

    This patch fixes an ICE for a combination of:

    - -fstack-clash-protection
    - a frame that has SVE save slots
    - a frame that has no GPR save slots
    - a frame that has a VG save slot

    The allocation code was folding the SVE save slot allocation into
    the initial frame allocation, so that we had one allocation of
    size <size of SVE registers> + 16.  But the VG save code itself
    expected the allocations to remain separate, since it wants to
    store at a constant offset from SP or FP.

    The VG save isn't shrink-wrapped and so acts as a probe of the
    initial allocations.  It should therefore be safe to keep separate
    allocations in this case.

    The scans in locally_streaming_1.c expect no stack clash protection,
    so the patch forces that and adds a separate compile-only test for
    when protection is enabled.

    gcc/
            PR target/113995
            * config/aarch64/aarch64.cc (aarch64_expand_prologue): Don't
            fold the SVE allocation into the initial allocation if the
            initial allocation includes a VG save.

    gcc/testsuite/
            PR target/113995
            * gcc.target/aarch64/sme/locally_streaming_1.c: Require
            -fno-stack-clash-protection.
            * gcc.target/aarch64/sme/locally_streaming_1_scp.c: New test.=