From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 7555C3858C74; Sun, 25 Feb 2024 19:44:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7555C3858C74 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1708890251; bh=92O0G6alCnLpsJ9w05yHo3AKZwuroLuzFG6Pc9vCbmk=; h=From:To:Subject:Date:In-Reply-To:References:From; b=CFnQQNDPSzERFCpxufCOASjXXBs086k5ieE3GJBwNOnRN6zdRoMw4gQPTp3+D2v0W wx+D4PJpG+1stBPolr753jNy7CasYkIRAg6lXhv3UwWfNTO34MTApe4evlFue+5n95 oCfau7UPF+VMAhrBcP6WMAbFNOFs/nQ8t8DlNnLY= From: "anlauf at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/114012] overloaded unary operator called twice Date: Sun, 25 Feb 2024 19:44:09 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: fortran X-Bugzilla-Version: 13.2.1 X-Bugzilla-Keywords: wrong-code X-Bugzilla-Severity: normal X-Bugzilla-Who: anlauf at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: anlauf at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D114012 anlauf at gcc dot gnu.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anlauf at gcc dot gnu.org Assignee|unassigned at gcc dot gnu.org |anlauf at gcc dot g= nu.org --- Comment #2 from anlauf at gcc dot gnu.org --- The following patch fixes the redundant procedure invocation: diff --git a/gcc/fortran/trans-expr.cc b/gcc/fortran/trans-expr.cc index 118dfd7c9b2..581b3786dea 100644 --- a/gcc/fortran/trans-expr.cc +++ b/gcc/fortran/trans-expr.cc @@ -6691,6 +6692,10 @@ gfc_conv_procedure_call (gfc_se * se, gfc_symbol * s= ym, { tree efield; + /* Evaluate arguments just once. */ + if (e->expr_type !=3D EXPR_VARIABLE) + parmse.expr =3D save_expr (parmse.expr); + /* Set the _data field. */ tmp =3D gfc_class_data_get (var); efield =3D fold_convert (TREE_TYPE (tmp),=