From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 830653858402; Thu, 29 Feb 2024 22:20:29 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 830653858402
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1709245229;
	bh=WEYA0dNajOCUB7Tv3+/Ysp1HxoZ+1JAhSIDjASaGlZc=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=EmFsHSdZZI8lN/QYq1N5ZHLCz/h0M6e/HZVNBDl/UjJ2CLSl8pR4EFvC2EZWJRU3g
	 zEHjmfVTOHgTctkV76CvRkxDi2WPcsi0emDdH0V0mcjvMqgoA8N9fmrnWepTEdfoni
	 AyV0NS0/xIYEojyMrzmM2gnCdGVaqqbPH6bsK0gM=
From: "palmer at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/114175] [13/14] RISC-V: Execution test failures on
 gcc.dg/c23-stdarg-6.c
Date: Thu, 29 Feb 2024 22:20:29 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: palmer at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-114175-4-VcbFLuNDW5@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-114175-4@http.gcc.gnu.org/bugzilla/>
References: <bug-114175-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D114175

--- Comment #15 from palmer at gcc dot gnu.org ---
It's a little easier to see from the float version of the code.

$ cat gcc/testsuite/gcc.dg/c23-stdarg-6.c=20
/* Test C23 variadic functions with no named parameters, or last named
   parameter with a declaration not allowed in C17.  Execution tests.  */
/* { dg-do run } */
/* { dg-options "-std=3Dc23 -pedantic-errors" } */

#include <stdarg.h>
#include <stdio.h>

extern void abort (void);
extern void exit (int);
struct s { char c[1000]; };

struct s
f (...)
{
  va_list ap;
  va_start (ap);
  int r =3D va_arg (ap, double);
  va_end (ap);
  struct s ret =3D {};
  ret.c[0] =3D r;
  ret.c[999] =3D 42;
  return ret;
}

int
main ()
{
  struct s x =3D f (1.0);
  fprintf(stderr, "%d\n", x.c[0]);
  if (x.c[0] !=3D 1)
    abort ();
  exit (0);
}
$ riscv64-unknown-linux-gnu-gcc gcc/testsuite/gcc.dg/c23-stdarg-6.c -o test
-std=3Dc2x -static -O3
$ riscv64-unknown-linux-gnu-objdump -d test
...
0000000000010412 <main>:
...
   1042e:       850a                    mv      a0,sp
...
   10438:       112000ef                jal     1054a <f>
...
000000000001054a <f>:
   1054a:       f20507d3                fmv.d.x fa5,a0

The psABI says

    A callee with variadic arguments is responsible for copying the contents
    of registers used to pass variadic arguments to the vararg save area,
    which must be contiguous with arguments passed on the stack.

which I'm taking to mean the "1.0" is meant to be passed in a register.  It
also says

    Values are returned in the same manner as a first named argument of the
    same type would be passed. If such an argument would have been passed by
    reference, the caller allocates memory for the return value, and passes
    the address as an implicit first parameter.

So I think we're screwing up both ends of this one: the caller is passing t=
he
return struct in a0 (losing the first arg), which the callee is obtaining t=
he
first argument from a0 (losing the return struct).

That all very much seems like a backend bug to me.=