public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/114175] [13/14] Execution test failures on gcc.dg/c23-stdarg-6.c on multiple targets Date: Sat, 30 Mar 2024 03:54:24 +0000 [thread overview] Message-ID: <bug-114175-4-jlAokgs3ib@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-114175-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114175 --- Comment #50 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-13 branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:af189fa9c2c4a0c8230f308e1934f046df3e80f7 commit r13-8509-gaf189fa9c2c4a0c8230f308e1934f046df3e80f7 Author: Jakub Jelinek <jakub@redhat.com> Date: Tue Mar 19 09:13:32 2024 +0100 rs6000: Fix up setup_incoming_varargs [PR114175] The c23-stdarg-8.c test (as well as the new test below added to cover even more cases) FAIL on powerpc64le-linux and presumably other powerpc* targets as well. Like in the r14-9503-g218d174961 change on x86-64 we need to advance next_cum after the hidden return pointer argument even in case where there are no user arguments before ... in C23. The following patch does that. There is another TYPE_NO_NAMED_ARGS_STDARG_P use later on: if (!TYPE_NO_NAMED_ARGS_STDARG_P (TREE_TYPE (current_function_decl)) && targetm.calls.must_pass_in_stack (arg)) first_reg_offset += rs6000_arg_size (TYPE_MODE (arg.type), arg.type); but I believe it was added there in r13-3549-g4fe34cdc unnecessarily, when there is no hidden return pointer argument, arg.type is NULL and must_pass_in_stack_var_size as well as must_pass_in_stack_var_size_or_pad return false in that case, and for the TYPE_NO_NAMED_ARGS_STDARG_P case with hidden return pointer argument that argument should have pointer type and it is the first argument, so must_pass_in_stack shouldn't be true for it either. 2024-03-19 Jakub Jelinek <jakub@redhat.com> PR target/114175 * config/rs6000/rs6000-call.cc (setup_incoming_varargs): Only skip rs6000_function_arg_advance_1 for TYPE_NO_NAMED_ARGS_STDARG_P functions if arg.type is NULL. * gcc.dg/c23-stdarg-9.c: New test. (cherry picked from commit 8f85b46337f90c3126b9cefd72ffd29eb9a4ebf3)
next prev parent reply other threads:[~2024-03-30 3:54 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-29 17:45 [Bug target/114175] New: [14] RISC-V: Execution tests on gcc.dg/c23-stdarg-6.c ewlu at rivosinc dot com 2024-02-29 17:51 ` [Bug target/114175] [14] RISC-V: Execution test failures " jakub at gcc dot gnu.org 2024-02-29 18:49 ` ewlu at rivosinc dot com 2024-02-29 18:53 ` jakub at gcc dot gnu.org 2024-02-29 18:57 ` ewlu at rivosinc dot com 2024-02-29 18:59 ` jakub at gcc dot gnu.org 2024-02-29 19:01 ` jakub at gcc dot gnu.org 2024-02-29 19:56 ` [Bug target/114175] [13/14] " jakub at gcc dot gnu.org 2024-02-29 20:03 ` jakub at gcc dot gnu.org 2024-02-29 20:07 ` palmer at gcc dot gnu.org 2024-02-29 20:09 ` jakub at gcc dot gnu.org 2024-02-29 20:09 ` jakub at gcc dot gnu.org 2024-02-29 20:20 ` jakub at gcc dot gnu.org 2024-02-29 20:22 ` jakub at gcc dot gnu.org 2024-02-29 21:28 ` palmer at gcc dot gnu.org 2024-02-29 22:20 ` palmer at gcc dot gnu.org 2024-02-29 22:46 ` ewlu at rivosinc dot com 2024-02-29 23:33 ` palmer at gcc dot gnu.org 2024-02-29 23:58 ` palmer at gcc dot gnu.org 2024-03-11 23:32 ` ewlu at rivosinc dot com 2024-03-13 2:30 ` xry111 at gcc dot gnu.org 2024-03-13 2:32 ` sjames at gcc dot gnu.org 2024-03-13 2:34 ` xry111 at gcc dot gnu.org 2024-03-15 21:46 ` sjames at gcc dot gnu.org 2024-03-15 23:10 ` jakub at gcc dot gnu.org 2024-03-16 14:17 ` cvs-commit at gcc dot gnu.org 2024-03-17 10:54 ` xry111 at gcc dot gnu.org 2024-03-18 10:16 ` [Bug target/114175] [13/14] Execution test failures on gcc.dg/c23-stdarg-6.c on multiple targets jakub at gcc dot gnu.org 2024-03-18 10:18 ` xry111 at gcc dot gnu.org 2024-03-18 10:54 ` jakub at gcc dot gnu.org 2024-03-18 11:37 ` jakub at gcc dot gnu.org 2024-03-18 12:16 ` jakub at gcc dot gnu.org 2024-03-18 18:56 ` ewlu at rivosinc dot com 2024-03-19 8:15 ` cvs-commit at gcc dot gnu.org 2024-03-19 8:15 ` cvs-commit at gcc dot gnu.org 2024-03-19 8:38 ` cvs-commit at gcc dot gnu.org 2024-03-19 8:45 ` xry111 at gcc dot gnu.org 2024-03-19 8:51 ` cvs-commit at gcc dot gnu.org 2024-03-19 8:53 ` jakub at gcc dot gnu.org 2024-03-19 16:56 ` cvs-commit at gcc dot gnu.org 2024-03-20 7:13 ` xry111 at gcc dot gnu.org 2024-03-20 16:01 ` cvs-commit at gcc dot gnu.org 2024-03-20 16:01 ` cvs-commit at gcc dot gnu.org 2024-03-20 16:01 ` cvs-commit at gcc dot gnu.org 2024-03-20 16:01 ` cvs-commit at gcc dot gnu.org 2024-03-20 16:02 ` cvs-commit at gcc dot gnu.org 2024-03-20 16:02 ` cvs-commit at gcc dot gnu.org 2024-03-20 16:02 ` cvs-commit at gcc dot gnu.org 2024-03-30 2:14 ` cvs-commit at gcc dot gnu.org 2024-03-30 3:54 ` cvs-commit at gcc dot gnu.org 2024-03-30 3:54 ` cvs-commit at gcc dot gnu.org [this message] 2024-03-30 3:54 ` cvs-commit at gcc dot gnu.org 2024-03-30 3:54 ` cvs-commit at gcc dot gnu.org 2024-03-30 3:54 ` cvs-commit at gcc dot gnu.org 2024-03-30 3:54 ` cvs-commit at gcc dot gnu.org 2024-03-30 3:54 ` cvs-commit at gcc dot gnu.org 2024-03-30 3:55 ` cvs-commit at gcc dot gnu.org 2024-03-30 3:55 ` cvs-commit at gcc dot gnu.org 2024-03-30 3:55 ` cvs-commit at gcc dot gnu.org 2024-03-30 3:55 ` cvs-commit at gcc dot gnu.org 2024-03-30 5:49 ` cvs-commit at gcc dot gnu.org 2024-03-30 5:49 ` cvs-commit at gcc dot gnu.org 2024-04-04 16:26 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-114175-4-jlAokgs3ib@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).