[Bug target/114189] New: Target implements obsolete vcond{,u,eq} expanders

[Bug target/114189] New: Target implements obsolete vcond{,u,eq} expanders

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

            Bug ID: 114189
           Summary: Target implements obsolete vcond{,u,eq} expanders
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rguenth at gcc dot gnu.org
  Target Milestone: ---

The listed targets implement any of vcond, vcondu or vcondeq expanders where
the modern way of exposing vector conditional instructions is using
mask generating vec_cmp{,u,eq} and vcond_mask expanders.

vcond, vcondu and vcondeq optabs will be retired in the future.

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
The following shows them all:

grep 'vcond[<eu]' gcc/config/*/*.md

ia64 and sparc are the only targets that do not implement any vec_cmp{,u,eq}
pattern.

mips, sparc and ia64 do not implement any vcond_mask pattern.

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Created attachment 58426
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58426&action=edit
patch to remove use of the legacy optabs

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
arm is OK -
https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/7755/artifact/artifacts/artifacts.precommit/notify/mail-body.txt
loongarch is also reportedly OK

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
aarch64 reports just

FAIL: gcc.target/aarch64/if-compare_2.c check-function-bodies bar1
FAIL: gcc.target/aarch64/if-compare_2.c check-function-bodies bar2

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-06-17
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
.

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by hongtao Liu <liuhongt@gcc.gnu.org>:

https://gcc.gnu.org/g:aac00d09859cc5934bd0f7493d537b8430337773

commit r15-1638-gaac00d09859cc5934bd0f7493d537b8430337773
Author: liuhongt <hongtao.liu@intel.com>
Date:   Thu Jun 20 12:41:13 2024 +0800

    Optimize a < 0 ? -1 : 0 to (signed)a >> 31.

    Try to optimize x < 0 ? -1 : 0 into (signed) x >> 31
    and x < 0 ? 1 : 0 into (unsigned) x >> 31.

    Move the optimization did in ix86_expand_int_vcond to match.pd

    gcc/ChangeLog:

            PR target/114189
            * match.pd: Simplify a < 0 ? -1 : 0 to (signed) >> 31 and a <
            0 ? 1 : 0 to (unsigned) a >> 31 for vector integer type.

    gcc/testsuite/ChangeLog:

            * gcc.target/i386/avx2-pr115517.c: New test.
            * gcc.target/i386/avx512-pr115517.c: New test.
            * g++.target/i386/avx2-pr115517.C: New test.
            * g++.target/i386/avx512-pr115517.C: New test.
            * g++.dg/tree-ssa/pr88152-1.C: Adjust testcase.