[Bug target/114189] New: Target implements obsolete vcond{,u,eq} expanders

[Bug target/114189] New: Target implements obsolete vcond{,u,eq} expanders

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

            Bug ID: 114189
           Summary: Target implements obsolete vcond{,u,eq} expanders
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rguenth at gcc dot gnu.org
  Target Milestone: ---

The listed targets implement any of vcond, vcondu or vcondeq expanders where
the modern way of exposing vector conditional instructions is using
mask generating vec_cmp{,u,eq} and vcond_mask expanders.

vcond, vcondu and vcondeq optabs will be retired in the future.

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
The following shows them all:

grep 'vcond[<eu]' gcc/config/*/*.md

ia64 and sparc are the only targets that do not implement any vec_cmp{,u,eq}
pattern.

mips, sparc and ia64 do not implement any vcond_mask pattern.

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Created attachment 58426
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58426&action=edit
patch to remove use of the legacy optabs

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
arm is OK -
https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/7755/artifact/artifacts/artifacts.precommit/notify/mail-body.txt
loongarch is also reportedly OK

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
aarch64 reports just

FAIL: gcc.target/aarch64/if-compare_2.c check-function-bodies bar1
FAIL: gcc.target/aarch64/if-compare_2.c check-function-bodies bar2

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-06-17
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
.

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by hongtao Liu <liuhongt@gcc.gnu.org>:

https://gcc.gnu.org/g:aac00d09859cc5934bd0f7493d537b8430337773

commit r15-1638-gaac00d09859cc5934bd0f7493d537b8430337773
Author: liuhongt <hongtao.liu@intel.com>
Date:   Thu Jun 20 12:41:13 2024 +0800

    Optimize a < 0 ? -1 : 0 to (signed)a >> 31.

    Try to optimize x < 0 ? -1 : 0 into (signed) x >> 31
    and x < 0 ? 1 : 0 into (unsigned) x >> 31.

    Move the optimization did in ix86_expand_int_vcond to match.pd

    gcc/ChangeLog:

            PR target/114189
            * match.pd: Simplify a < 0 ? -1 : 0 to (signed) >> 31 and a <
            0 ? 1 : 0 to (unsigned) a >> 31 for vector integer type.

    gcc/testsuite/ChangeLog:

            * gcc.target/i386/avx2-pr115517.c: New test.
            * gcc.target/i386/avx512-pr115517.c: New test.
            * g++.target/i386/avx2-pr115517.C: New test.
            * g++.target/i386/avx512-pr115517.C: New test.
            * g++.dg/tree-ssa/pr88152-1.C: Adjust testcase.

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[liuhongt at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189
Bug 114189 depends on bug 115517, which changed state.

Bug 115517 Summary: Fix x86 regressions after dropping uses of vcond{,u,eq}_optab
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115517

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[linkw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189
Bug 114189 depends on bug 115659, which changed state.

Bug 115659 Summary: powerpc fallout from removing vcond{,u,eq} patterns
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115659

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|x86_64-*-*, i?86-*-*,       |x86_64-*-*, i?86-*-*,
                   |sparc, s390, powerpc, mips, |sparc, s390, mips,
                   |loongarch, ia64, gcn, arm,  |loongarch, ia64, gcn, arm,
                   |aarch64,                    |aarch64,

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
powerpc has removed the obsolete expanders.

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot gnu.org

--- Comment #8 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
There are 2 entries for vcond_mask in the internal manual:

'vcond_mask_MN'
     Similar to 'vcondMN' but operand 3 holds a pre-computed result of
     vector comparison.

'vcond_mask_MN'
     Set each element of operand 0 to the corresponding element of
     operand 2 or operand 3.  Choose operand 2 if both the element index
     is less than operand 4 plus operand 5 and the corresponding element
     of operand 1 is nonzero:

          for (i = 0; i < GET_MODE_NUNITS (M); i++)
            op0[i] = i < op4 + op5 && op1[i] ? op2[i] : op3[i];

     Operands 0, 2 and 3 have mode M.  Operand 1 has mode N.  Operands 4
     and 5 have a target-dependent scalar integer mode

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[rguenther at suse dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

--- Comment #9 from rguenther at suse dot de <rguenther at suse dot de> ---
On Fri, 12 Jul 2024, ebotcazou at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189
> 
> Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |ebotcazou at gcc dot gnu.org
> 
> --- Comment #8 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
> There are 2 entries for vcond_mask in the internal manual:
> 
> 'vcond_mask_MN'
>      Similar to 'vcondMN' but operand 3 holds a pre-computed result of
>      vector comparison.
> 
> 'vcond_mask_MN'

This should be vcond_mask_len_MN I think.

>      Set each element of operand 0 to the corresponding element of
>      operand 2 or operand 3.  Choose operand 2 if both the element index
>      is less than operand 4 plus operand 5 and the corresponding element
>      of operand 1 is nonzero:
> 
>           for (i = 0; i < GET_MODE_NUNITS (M); i++)
>             op0[i] = i < op4 + op5 && op1[i] ? op2[i] : op3[i];
> 
>      Operands 0, 2 and 3 have mode M.  Operand 1 has mode N.  Operands 4
>      and 5 have a target-dependent scalar integer mode

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

--- Comment #10 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Stefan Schulze Frielinghaus
<stefansf@gcc.gnu.org>:

https://gcc.gnu.org/g:75c0bf997d2808561451e62aa6b7ae7c8e32b9e9

commit r15-2058-g75c0bf997d2808561451e62aa6b7ae7c8e32b9e9
Author: Stefan Schulze Frielinghaus <stefansf@gcc.gnu.org>
Date:   Tue Jul 16 10:41:52 2024 +0200

    s390: Drop vcond{,u} expanders

    Optabs vcond{,u} will be removed for GCC 15.  Since regtest shows no
    fallout, dropping the expanders, now.

    gcc/ChangeLog:

            PR target/114189
            * config/s390/vector.md (V_HW2): Remove.
            (vcond<V_HW:mode><V_HW2:mode>): Remove.
            (vcondu<V_HW:mode><V_HW2:mode>): Remove.

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

--- Comment #11 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #4)
> aarch64 reports just
> 
> FAIL: gcc.target/aarch64/if-compare_2.c check-function-bodies bar1
> FAIL: gcc.target/aarch64/if-compare_2.c check-function-bodies bar2

I think these 2 are now fixed after the fixes for PR 115659.
There is also missing andc/iorc patterns. 
Which I am testing a change for them. I am doing it as part of using andc/iorc
for scalars change due to be able to use them for vectors too.

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

--- Comment #12 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #11)
> (In reply to Richard Biener from comment #4)
> > aarch64 reports just
> > 
> > FAIL: gcc.target/aarch64/if-compare_2.c check-function-bodies bar1
> > FAIL: gcc.target/aarch64/if-compare_2.c check-function-bodies bar2
> 
> I think these 2 are now fixed after the fixes for PR 115659.
> There is also missing andc/iorc patterns. 
> Which I am testing a change for them. I am doing it as part of using
> andc/iorc for scalars change due to be able to use them for vectors too.

Actually I take that back, these are no longer vectorized. 
Let me file that as a seperate issue.

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|x86_64-*-*, i?86-*-*,       |sparc, mips, loongarch,
                   |sparc, mips, loongarch,     |ia64, gcn, arm, aarch64,
                   |ia64, gcn, arm, aarch64,    |

--- Comment #13 from Richard Biener <rguenth at gcc dot gnu.org> ---
The i386 backend is also clear of vcond{,u,eq} patterns, there's some XFAILed
fallout when just SSE is available (PR115683).

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|14.0                        |15.0
                 CC|                            |ams at gcc dot gnu.org,
                   |                            |chenglulu at loongson dot cn,
                   |                            |rearnsha at gcc dot gnu.org

--- Comment #14 from Richard Biener <rguenth at gcc dot gnu.org> ---
CCing maintainers for loongarch, arm/aarch64 and gcn.

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189
Bug 114189 depends on bug 116041, which changed state.

Bug 116041 Summary: aarch64 fallout from removing vcond{,u,eq} patterns
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116041

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189

--- Comment #15 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by LuluCheng <chenglulu@gcc.gnu.org>:

https://gcc.gnu.org/g:0498f8bda1d08b8ed8100d759917792baf2da15f

commit r15-2878-g0498f8bda1d08b8ed8100d759917792baf2da15f
Author: Lulu Cheng <chenglulu@loongson.cn>
Date:   Thu Aug 8 10:39:54 2024 +0800

    LoongArch: Drop vcond{,u} expanders.

    Optabs vcond{,u} will be removed for GCC 15.  Since regtest shows no
    fallout, dropping the expanders, now.

    gcc/ChangeLog:

            PR target/114189
            * config/loongarch/lasx.md (vcondu<LASX:mode><ILASX:mode>): Delete.
            (vcond<LASX:mode><LASX_2:mode>): Likewise.
            * config/loongarch/lsx.md (vcondu<LSX:mode><ILSX:mode>): Likewise.
            (vcond<LSX:mode><LSX_2:mode>): Likewise.

[Bug target/114189] Target implements obsolete vcond{,u,eq} expanders

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114189
Bug 114189 depends on bug 115490, which changed state.

Bug 115490 Summary: i386 fallout from removing vcond{,u,eq} patterns
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115490

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |DUPLICATE