public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "akihiko.odaki at daynix dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug sanitizer/114217] -fsanitize=alignment false positive with intended unaligned struct member access Date: Mon, 04 Mar 2024 05:26:52 +0000 [thread overview] Message-ID: <bug-114217-4-4FXujgqA2z@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-114217-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114217 --- Comment #8 from Akihiko Odaki <akihiko.odaki at daynix dot com> --- (In reply to Jakub Jelinek from comment #7) > GCC actually doesn't diagnose on mere pointer assignment, but what triggers > the alignment check is > &entry->offset > even when the code later on just takes its address, entry must be > sufficiently aligned, otherwise entry->offset is invalid. > Under standard C rules, already forming the pointer would be UB, so > somewhere in the caller when you prepare what to pass to the f function. > > If you want something that will still be invalid C, > but will not trigger UBSAN errors, then e.g. > unsigned long long h(struct dir_entry *entry) > { > return get_unaligned((unsigned long long *) (((char *) entry) + offsetof > (struct dir_entry, offset))); > } > will do. It would certainly workaround the issue, but it's only dirtier and brings no benefit except suppressed UBSan errors. Why not allow get_unaligned(&entry->offset) when UBSan does not complain about that hack? > If you want something that will be valid even in C, don't pass struct > dir_entry *entry > argument, but void *entry instead, and use e.g. > __get_unaligned_t(__typeof(((struct dir_entry *)0)->offset), ((char > *)entry)+offsetof(struct dir_entry, offset))) > You can surely hide that all under some macro. The definition still involves UB for ((struct dir_entry *)0)->offset. Perhaps __typeof() may be considered as an exception, but what if offsetof() is defined as follows? #define offsetof(T, x) ((uintptr_t)&(((T *)0)->x)) GCC does provide __builtin_offsetof(), but I think definitions of offsetof() like this are still prevalent, and expected to work although it's UB. If GCC tolerates this kind of trick, why not tolerate get_unaligned(&entry->offset)?
next prev parent reply other threads:[~2024-03-04 5:26 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-03 7:03 [Bug sanitizer/114217] New: " akihiko.odaki at daynix dot com 2024-03-03 7:10 ` [Bug sanitizer/114217] " pinskia at gcc dot gnu.org 2024-03-03 7:15 ` pinskia at gcc dot gnu.org 2024-03-03 7:19 ` akihiko.odaki at daynix dot com 2024-03-03 7:22 ` pinskia at gcc dot gnu.org 2024-03-03 7:29 ` akihiko.odaki at daynix dot com 2024-03-03 7:46 ` akihiko.odaki at daynix dot com 2024-03-03 19:01 ` jakub at gcc dot gnu.org 2024-03-04 5:26 ` akihiko.odaki at daynix dot com [this message] 2024-03-04 7:46 ` jakub at gcc dot gnu.org 2024-03-04 7:54 ` jakub at gcc dot gnu.org 2024-03-04 8:11 ` akihiko.odaki at daynix dot com 2024-03-04 8:35 ` jakub at gcc dot gnu.org 2024-03-04 8:45 ` akihiko.odaki at daynix dot com 2024-03-04 21:48 ` i at maskray dot me
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-114217-4-4FXujgqA2z@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).