From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 74B2F385840E; Tue,  5 Mar 2024 12:53:13 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 74B2F385840E
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1709643193;
	bh=/k/KjBqxnNgTjZ61n3nylkQeGyML2jQErJnf1BE6xxg=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=v5SXkD9MwQavbEsxfFMvqEJj/Y9wZPOSGSUebQ56EKEXWlm1reTRipNgNAal880xO
	 0L9KCWPDry9gptwoC7tW7/fHDhP3zk8Uviq50Can/VvyzLx/k8po+GIPkr+K75p8Gn
	 YdTPhmdmQs09zrVR3UQlGgpHoBwFbT93CBvenrok=
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/114232] [14 regression] ICE when building rr-5.7.0 with
 LTO on x86
Date: Tue, 05 Mar 2024 12:53:12 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ubizjak at gmail dot com
X-Bugzilla-Target-Milestone: 14.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-114232-4-4VSPrZvuW5@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-114232-4@http.gcc.gnu.org/bugzilla/>
References: <bug-114232-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D114232

--- Comment #20 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Uro=C5=A1 Bizjak from comment #19)
> (In reply to Jan Hubicka from comment #18)
> > But the problem here is more that optab initializations happens only at
> > the optimization_node changes and not if we switch from hot function to
> > cold?
>=20
> I think solving optab init problem is a better solution than the target
> patch from comment #10. Using optimize_function_for_size_p in named patte=
rn
> predicate would avoid using the non-optimal pattern also in cold function=
s,
> and would be preferrable to using optimize_size.

It would be very costly IMHO, because on every set_cfun we'd need to compute
optimize_function_for_size_p for both the old and new function and find out
where to attach the additional optab tables. set_cfun can be called million=
s of
times.=