public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/114232] [14 regression] ICE when building rr-5.7.0 with LTO on x86
Date: Tue, 05 Mar 2024 11:58:08 +0000	[thread overview]
Message-ID: <bug-114232-4-IzdmQtJYVa@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-114232-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114232

--- Comment #15 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Yeah, indeed, the optabs enable flags are cached in the optimization node, so
it is ok
to check the optimization flags in there, or target flags as well, but
optimize_function_for_*_p is not, because it depends also on
node->count/node->frequency of the current function but multiple functions can
have the same optimization node/target node combo.
Seems i386 is the only backend which does something like that.
I believe this has been fixed in the backend in the past already, see e.g.
PR92791
While
      if (opts != optimization_default_node)
        {
          init_tree_optimization_optabs (opts);
          if (TREE_OPTIMIZATION_OPTABS (opts))
            this_fn_optabs = (struct target_optabs *)
              TREE_OPTIMIZATION_OPTABS (opts);
        }
in invoke_set_current_function_hook maybe (hopefully) makes stuff work right
for the different options, that certainly doesn't account for
node->function/node->count.

Seems various backends use e.g. optimize_size or !optimize_size or optimize > 0
etc. in
insn-flags.h, so perhaps change optimize_function_for_size_p (cfun) to
optimize_size?

  parent reply	other threads:[~2024-03-05 11:58 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05  7:04 [Bug target/114232] New: " sjames at gcc dot gnu.org
2024-03-05  7:05 ` [Bug target/114232] " sjames at gcc dot gnu.org
2024-03-05  7:05 ` sjames at gcc dot gnu.org
2024-03-05  7:05 ` sjames at gcc dot gnu.org
2024-03-05  8:24 ` ubizjak at gmail dot com
2024-03-05  8:59 ` ubizjak at gmail dot com
2024-03-05  9:10 ` rguenth at gcc dot gnu.org
2024-03-05  9:12 ` rguenth at gcc dot gnu.org
2024-03-05  9:14 ` rguenth at gcc dot gnu.org
2024-03-05  9:53 ` ubizjak at gmail dot com
2024-03-05 10:30 ` ubizjak at gmail dot com
2024-03-05 10:36 ` rguenth at gcc dot gnu.org
2024-03-05 10:38 ` jakub at gcc dot gnu.org
2024-03-05 10:48 ` ubizjak at gmail dot com
2024-03-05 10:52 ` rguenther at suse dot de
2024-03-05 11:58 ` jakub at gcc dot gnu.org [this message]
2024-03-05 12:09 ` ubizjak at gmail dot com
2024-03-05 12:57   ` Jan Hubicka
2024-03-05 12:21 ` jakub at gcc dot gnu.org
2024-03-05 12:30 ` hubicka at ucw dot cz
2024-03-05 12:49 ` ubizjak at gmail dot com
2024-03-05 12:53 ` jakub at gcc dot gnu.org
2024-03-05 12:57 ` hubicka at ucw dot cz
2024-03-05 13:06 ` rguenther at suse dot de
2024-03-05 13:08 ` ubizjak at gmail dot com
2024-03-05 13:11 ` jakub at gcc dot gnu.org
2024-03-05 13:43 ` ubizjak at gmail dot com
2024-03-05 14:13 ` hubicka at ucw dot cz
2024-03-06  8:47 ` ubizjak at gmail dot com
2024-03-06 19:54 ` cvs-commit at gcc dot gnu.org
2024-03-06 20:10 ` ubizjak at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-114232-4-IzdmQtJYVa@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).