From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id CF697385841A; Thu,  7 Mar 2024 15:06:22 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CF697385841A
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1709823982;
	bh=aoX2G5PN5XxyqdSa2MZEeygepowsWB4XFhedeXIx1iw=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=gsC8oRRgYZ6So80ekgQKN8nmG8w83x75Q5SWIulPptw1QI4NwGzLAwQPcX129DAM+
	 run0s2OsD3kNkEcj0DIUm7agMz80Vz4eBMYR7GNvQ3SjETIjdETM9Dh3ZftyPZkgTf
	 dA6yI/ouT2gs+pCkR76EtgMJN9nPT4kMwe3/Ehhs=
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/114233] Newly-introduced pr113617.C test fails on Darwin
Date: Thu, 07 Mar 2024 15:06:22 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: link-failure, testsuite-fail
X-Bugzilla-Severity: normal
X-Bugzilla-Who: iains at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-114233-4-ZZZjI9E3qo@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-114233-4@http.gcc.gnu.org/bugzilla/>
References: <bug-114233-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D114233

--- Comment #4 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Francois-Xavier Coudert from comment #3)
> Jakub has posted a patch in the linker PR (thanks!).
>=20
> But there remains a darwin bug. The test in check_effective_target_shared
> actually works with C, but not with C++, because:
>=20

> diff --git a/gcc/testsuite/lib/target-supports.exp
> b/gcc/testsuite/lib/target-supports.exp
> index ae33c4f1e3a..467b539b20d 100644
> --- a/gcc/testsuite/lib/target-supports.exp
> +++ b/gcc/testsuite/lib/target-supports.exp
> @@ -1390,7 +1390,7 @@ proc check_effective_target_shared { } {
>      # here to be undefined.
>      set extra_flags ""
>      if { [istarget *-*-darwin\[912\]*] } {
> -      set extra_flags "-Wl,-U,_foo,-U,_bar"
> +      set extra_flags "-Wl,-U,_foo,-U,_bar,-U,__Z3foov"
>      }

Ah that's an omission on my part, the fix applied recently was incomplete :=
-(.
(FWIW, the "C" fix doubled the number of libphobos tests, IIRC).=