public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/114233] Newly-introduced pr113617.C test fails on Darwin
Date: Fri, 08 Mar 2024 14:19:59 +0000	[thread overview]
Message-ID: <bug-114233-4-kETR2UEmDF@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-114233-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114233

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:8263a4b6505f84973c2ed2fb8d4f2036ca335ff3

commit r14-9392-g8263a4b6505f84973c2ed2fb8d4f2036ca335ff3
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Mar 8 15:18:56 2024 +0100

    testsuite: Fix up pr113617 test for darwin [PR113617]

    The test attempts to link a shared library, and apparently Darwin doesn't
    allow by default for shared libraries to contain undefined symbols.

    The following patch just adds dummy definitions for the symbols, so that
    the library no longer has any undefined symbols at least in my linux
    testing.
    Furthermore, for target { !shared } targets (like darwin until the it is
    fixed in target-supports.exp), because we then link a program rather than
    shared library, the patch also adds a dummy main definition so that it
    can link.

    2024-03-08  Jakub Jelinek  <jakub@redhat.com>

            PR rtl-optimization/113617
            PR target/114233
            * g++.dg/other/pr113617.C: Define -DSHARED when linking with
-shared.
            * g++.dg/other/pr113617-aux.cc: Add definitions for used methods
and
            templates not defined elsewhere.

  parent reply	other threads:[~2024-03-08 14:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05  7:24 [Bug target/114233] New: " fxcoudert at gcc dot gnu.org
2024-03-05  7:25 ` [Bug target/114233] " fxcoudert at gcc dot gnu.org
2024-03-06 20:32 ` iains at gcc dot gnu.org
2024-03-07 13:31 ` fxcoudert at gcc dot gnu.org
2024-03-07 14:25 ` fxcoudert at gcc dot gnu.org
2024-03-07 15:06 ` iains at gcc dot gnu.org
2024-03-07 15:45 ` iains at gcc dot gnu.org
2024-03-08 14:19 ` cvs-commit at gcc dot gnu.org [this message]
2024-03-29 18:55 ` iains at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-114233-4-kETR2UEmDF@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).