public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/114245] Defaulted virtual destructors that do no work overwrite the vtable with `-O0`
Date: Tue, 28 May 2024 22:17:28 +0000	[thread overview]
Message-ID: <bug-114245-4-rAE0H2V4ub@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-114245-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114245

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=115050
         Resolution|---                         |WONTFIX
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
So I just debugged a bug report where the vtable storing in the deconstructor
found the bug in their code (PR 115050). It just happens with that store, it
causes a seg fault at runtime. Without the store the code seemly worked but
only on accident and I had to show that a deconstructor was called twice.

Having this store is definitely helpful for debugging code at -O0 and catching
undefined code early on.

So closing as won't fix. removing the vtable store is an optimization rather
than needed for correctness and having the vtable store there is very very
useful for debugabity of programs.

      parent reply	other threads:[~2024-05-28 22:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05 20:08 [Bug c++/114245] New: " mwinkler at blizzard dot com
2024-03-06  6:44 ` [Bug c++/114245] " pinskia at gcc dot gnu.org
2024-03-06  6:56 ` pinskia at gcc dot gnu.org
2024-03-06 16:14 ` mwinkler at blizzard dot com
2024-03-06 16:33 ` redi at gcc dot gnu.org
2024-03-06 16:38 ` jakub at gcc dot gnu.org
2024-05-28 22:17 ` pinskia at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-114245-4-rAE0H2V4ub@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).