From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 7A76C385801F; Wed,  6 Mar 2024 18:23:50 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7A76C385801F
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1709749430;
	bh=FhwkOKw7xkX5MTTKmzG9N4sCFQdR82yTtzIbVf3TZm4=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=mA3ICqyBQga1ZhWlQaPJXPLE0JfbJWF4y+bPcZ7Yw1GBq0RrfOLilG+fGhMTvcHa4
	 lLxlYQUFH33jsJHAFuaFJLMTojF+aS6a0cG6Vwaf0672SuBSvVb9LNK6BJzlpB+5ZH
	 1QXXCTIIL9b1RZPgDalmPTBJu4ACSi+8H+lmT4Mk=
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/114258] 2 stores happen when copying from a const
 union (array) to an union
Date: Wed, 06 Mar 2024 18:23:47 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 13.2.0
X-Bugzilla-Keywords: missed-optimization
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: pinskia at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on component
 bug_severity short_desc everconfirmed keywords
Message-ID: <bug-114258-4-rPIwx7lbHZ@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-114258-4@http.gcc.gnu.org/bugzilla/>
References: <bug-114258-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D114258

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2024-03-06
          Component|rtl-optimization            |middle-end
           Severity|normal                      |enhancement
            Summary|repeat store operation when |2 stores happen when
                   |copying a union             |copying from a const union
                   |                            |(array) to an union
     Ever confirmed|0                           |1
           Keywords|                            |missed-optimization

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Reduced testcase:
```
union U6 {
   short  f0;
   int f1;
};
union U6 g_13;
void func_1() {
  static const union U6 b[] =3D {{.f0 =3D 2}, {.f0 =3D 2}};
  g_13 =3D b[1];
}
```

It comes from the expansion of the assignment.


For aarch64 we have:
```
;; g_13 =3D b[1];

(insn 5 4 6 (set (reg:DI 101)
        (high:DI (symbol_ref:DI ("*.LANCHOR0") [flags 0x182])))
"/app/example.cpp":9:8 -1
     (nil))

(insn 6 5 7 (set (reg/f:DI 100)
        (lo_sum:DI (reg:DI 101)
            (symbol_ref:DI ("*.LANCHOR0") [flags 0x182])))
"/app/example.cpp":9:8 -1
     (expr_list:REG_EQUAL (symbol_ref:DI ("*.LANCHOR0") [flags 0x182])
        (nil)))

(insn 7 6 8 (set (mem/c:SI (reg/f:DI 100) [1 g_13D.4435+0 S4 A64])
        (const_int 0 [0])) "/app/example.cpp":9:8 -1
     (nil))

(insn 8 7 9 (set (reg:HI 102)
        (const_int 2 [0x2])) "/app/example.cpp":9:8 -1
     (nil))

(insn 9 8 10 (set (mem/c:HI (reg/f:DI 100) [2 g_13D.4435+0 S2 A64])
        (reg:HI 102)) "/app/example.cpp":9:8 -1
     (nil))

(insn 10 9 11 (set (mem/c:SI (reg/f:DI 100) [1 g_13D.4435+0 S4 A64])
        (const_int 0 [0])) "/app/example.cpp":9:8 -1
     (nil))

(insn 11 10 12 (set (reg:HI 103)
        (const_int 2 [0x2])) "/app/example.cpp":9:8 -1
     (nil))

(insn 12 11 0 (set (mem/c:HI (reg/f:DI 100) [2 g_13D.4435+0 S2 A64])
        (reg:HI 103)) "/app/example.cpp":9:8 -1
     (nil))
```

GCC could do better here in the expansion.=