public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "amonakov at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/114261] [13/14 Regression] Scheduling takes excessive time (97%) since r13-5154-g733a1b777f1
Date: Wed, 13 Mar 2024 13:56:16 +0000	[thread overview]
Message-ID: <bug-114261-4-SJiEhFzH4h@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-114261-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114261

--- Comment #8 from Alexander Monakov <amonakov at gcc dot gnu.org> ---
If we want to get rid of the compilation time regression sooner rather than
later, I can suggest limiting my change only to functions that call setjmp:

diff --git a/gcc/sched-deps.cc b/gcc/sched-deps.cc
index c23218890f..ae23f55274 100644
--- a/gcc/sched-deps.cc
+++ b/gcc/sched-deps.cc
@@ -3695,7 +3695,7 @@ deps_analyze_insn (class deps_desc *deps, rtx_insn *insn)

       CANT_MOVE (insn) = 1;

-      if (!reload_completed)
+      if (!reload_completed && cfun->calls_setjmp)
        {
          /* Scheduling across calls may increase register pressure by
extending
             live ranges of pseudos over the call.  Worse, in presence of
setjmp


That way we retain the "correctness fix" part of r13-5154-g733a1b777f1 and keep
the previous status quo on normal functions (quadraticness on asms like
demonstrated in comment #5 would also remain).

  parent reply	other threads:[~2024-03-13 13:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07  1:37 [Bug rtl-optimization/114261] New: [13/14 Regression] Scheduling takes excessive time (97%) patrick at rivosinc dot com
2024-03-07  1:38 ` [Bug rtl-optimization/114261] " patrick at rivosinc dot com
2024-03-07  1:40 ` pinskia at gcc dot gnu.org
2024-03-07  1:40 ` patrick at rivosinc dot com
2024-03-07  7:30 ` amonakov at gcc dot gnu.org
2024-03-07  7:51 ` patrick at rivosinc dot com
2024-03-07 20:36 ` law at gcc dot gnu.org
2024-03-11 16:30 ` amonakov at gcc dot gnu.org
2024-03-12  7:49 ` [Bug rtl-optimization/114261] [13/14 Regression] Scheduling takes excessive time (97%) since r13-5154-g733a1b777f1 rguenth at gcc dot gnu.org
2024-03-13  3:09 ` law at gcc dot gnu.org
2024-03-13 13:56 ` amonakov at gcc dot gnu.org [this message]
2024-03-13 14:08 ` rguenth at gcc dot gnu.org
2024-03-13 15:11 ` amonakov at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-114261-4-SJiEhFzH4h@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).