public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "lh_mouse at 126 dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/114262] New: Over-inlining when optimizing for size? Date: Thu, 07 Mar 2024 02:00:37 +0000 [thread overview] Message-ID: <bug-114262-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114262 Bug ID: 114262 Summary: Over-inlining when optimizing for size? Product: gcc Version: 14.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: tree-optimization Assignee: unassigned at gcc dot gnu.org Reporter: lh_mouse at 126 dot com Target Milestone: --- (https://gcc.godbolt.org/z/a4ox6oEfT) ``` struct impl; struct impl* get_impl(int key); int get_value(struct impl* p); extern __inline__ __attribute__((__gnu_inline__)) int get_value_by_key(int key) { struct impl* p = get_impl(key); if(!p) return -1; return get_value(p); } int real_get_value_by_key(int key) { return get_value_by_key(key); } ``` This is actually two functions, one is `gnu_inline` and the other is a non-inline one. It looks to me that if I mark a function `gnu_inline`, I assert that 'somewhere I shall provide an external definition for you' so when optimizing for size, GCC may generate a call instead of using the more complex inline definition. The `real_get_value_by_key` function is made a deliberate sibling call, so ideally this should be ``` real_get_value_by_key: jmp get_value_by_key ``` and not ``` real_get_value_by_key: push rsi call get_impl test rax, rax je .L2 mov rdi, rax pop rcx jmp get_value .L2: or eax, -1 pop rdx ret ``` It still gets inlined with `-finline-limit=0` and can only be disabled by `-fno-inline`. I have no idea how it is controlled. --------------------------- # Trivia These are two `gnu_inline` functions from the same library. Most of the time they should both be inlined in user code. However, external definitions are required when optimization is not turned on, or when their addresses are taken, so they must still exist. As they are unlikely to be used anyway, optimizing for size makes much more sense.
next reply other threads:[~2024-03-07 2:00 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-07 2:00 lh_mouse at 126 dot com [this message] 2024-03-07 2:07 ` [Bug tree-optimization/114262] " pinskia at gcc dot gnu.org 2024-03-07 2:33 ` [Bug ipa/114262] Over-inlining when optimizing for size with gnu_inline function lh_mouse at 126 dot com 2024-03-07 2:57 ` pinskia at gcc dot gnu.org 2024-03-07 3:20 ` lh_mouse at 126 dot com 2024-03-07 3:25 ` pinskia at gcc dot gnu.org 2024-03-07 15:55 ` Jan Hubicka 2024-03-07 15:55 ` hubicka at ucw dot cz 2024-03-07 17:08 ` lh_mouse at 126 dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-114262-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).