public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/114279] utc_clock does not support leap seconds
Date: Sat, 09 Mar 2024 00:29:30 +0000	[thread overview]
Message-ID: <bug-114279-4-vOzWkmSBWW@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-114279-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114279

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:f4a52c184d608325c14338b57f464f7d0bbc7526

commit r14-9405-gf4a52c184d608325c14338b57f464f7d0bbc7526
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Fri Mar 8 14:41:47 2024 +0000

    libstdc++: Fix parsing of leap seconds as chrono::utc_time [PR114279]

    Implementing all chrono::from_stream overloads in terms of
    chrono::sys_time meant that a leap second time like 23:59:60.001 cannot
    be parsed, because that cannot be represented in a sys_time.

    The fix to support parsing leap seconds as utc_time is to convert the
    parsed date to utc_time<days> and then add the parsed time to that,
    which allows the result to land in a leap second, rather than doing all
    the arithmetic with sys_time which doesn't have leap seconds.

    For local_time we also allow %S to parse a 60s value, because doing
    otherwise might disallow some valid uses. We can't know all use cases
    users have for treating times as local_time.

    For all other clocks, we can reject times that have 60 or 60.nnn as the
    seconds part, because that cannot occur in a valid UNIX, GPS, or TAI
    time. Since our chrono::file_clock uses sys_time, it can't occur for
    that clock either.

    In order to support this a new _M_is_leap_second member is needed in the
    _Parser type. This can be added at the end, where most targets currently
    have padding bytes. Similar to what I did recently for formatter _Spec
    structs, we can also reserve additional padding bits for future
    expansion.

    This also fixes bugs in the from_stream overloads for utc_time,
    tai_time, gps_time, and file_time, which were not using time_point_cast
    to explicitly convert to the result type. That's needed because the
    result type might have lower precision than the value returned from
    from_sys or from_utc, which has a precision no lower than seconds.

    libstdc++-v3/ChangeLog:

            PR libstdc++/114279
            * include/bits/chrono_io.h (_Parser::_M_is_leap_second): New
            data member.
            (_Parser::_M_reserved): Reserve padding bits for future use.
            (_Parser::operator()): Set _M_is_leap_second if %S reads 60s.
            (from_stream): Only allow _M_is_leap_second for utc_time and
            local_time. Adjust arithmetic for utc_time so that leap seconds
            are preserved. Use time_point_cast to convert to a possibly
            lower-precision result type.
            * testsuite/std/time/parse.cc: Move to ...
            * testsuite/std/time/parse/parse.cc: ... here.
            * testsuite/std/time/parse/114279.cc: New test.

  parent reply	other threads:[~2024-03-09  0:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-08  6:51 [Bug libstdc++/114279] New: " gnaggnoyil at gmail dot com
2024-03-08  7:59 ` [Bug libstdc++/114279] " redi at gcc dot gnu.org
2024-03-08 11:21 ` redi at gcc dot gnu.org
2024-03-09  0:29 ` cvs-commit at gcc dot gnu.org [this message]
2024-03-09  0:31 ` redi at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-114279-4-vOzWkmSBWW@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).