public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug analyzer/114286] ICE: in deref_rvalue, at analyzer/region-model.cc:2762 with _Atomic _BitInt() and -fanalyzer
Date: Tue, 19 Mar 2024 13:07:54 +0000	[thread overview]
Message-ID: <bug-114286-4-dXn3y5lKaj@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-114286-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114286

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:c7a774edbf802d79b95871ede5b80f6e9adf8e88

commit r14-9544-gc7a774edbf802d79b95871ede5b80f6e9adf8e88
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Tue Mar 19 09:06:45 2024 -0400

    analyzer: fixes to __atomic_{exchange,load,store} [PR114286]

    In r14-1497-gef768035ae8090 I added some support to the analyzer for
    __atomic_ builtins (enough to fix false positives I was seeing in
    my integration tests).

    Unfortunately I messed up the implementation of
    __atomic_{exchange,load,store}, leading to ICEs seen in
    PR analyzer/114286.

    Fixed thusly, fixing the ICEs.  Given that we're in stage 4, the patch
    doesn't add support for any of the various __atomic_compare_exchange
    builtins, so that these continue to fall back to the analyzer's
    "anything could happen" handling of unknown functions.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>

    gcc/analyzer/ChangeLog:
            PR analyzer/114286
            * kf.cc (class kf_atomic_exchange): Reimplement based on signature
            seen in gimple, rather than user-facing signature.
            (class kf_atomic_load): Likewise.
            (class kf_atomic_store): New.
            (register_atomic_builtins): Register kf_atomic_store.

    gcc/testsuite/ChangeLog:
            PR analyzer/114286
            * c-c++-common/analyzer/atomic-builtins-pr114286.c: New test.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>

  parent reply	other threads:[~2024-03-19 13:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-08 14:51 [Bug analyzer/114286] New: " zsojka at seznam dot cz
2024-03-08 15:20 ` [Bug analyzer/114286] " law at gcc dot gnu.org
2024-03-15 12:35 ` jakub at gcc dot gnu.org
2024-03-18 16:54 ` dmalcolm at gcc dot gnu.org
2024-03-18 18:20 ` dmalcolm at gcc dot gnu.org
2024-03-18 18:26 ` jakub at gcc dot gnu.org
2024-03-18 18:34 ` dmalcolm at gcc dot gnu.org
2024-03-19 13:07 ` cvs-commit at gcc dot gnu.org [this message]
2024-03-19 13:12 ` dmalcolm at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-114286-4-dXn3y5lKaj@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).