public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/114303] [11/12/13 Regression] ICE with constexpr if and accessing captures across nested generic lambdas Date: Tue, 14 May 2024 02:58:27 +0000 [thread overview] Message-ID: <bug-114303-4-EWGWPMgYkX@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-114303-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114303 --- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-13 branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>: https://gcc.gnu.org/g:47cac09307874ff1d640392e3d986453f34f7bcb commit r13-8767-g47cac09307874ff1d640392e3d986453f34f7bcb Author: Patrick Palka <ppalka@redhat.com> Date: Thu Apr 11 10:16:41 2024 -0400 c++: build_extra_args recapturing local specs [PR114303] r13-6452-g341e6cd8d603a3 made build_extra_args walk evaluated contexts first so that we prefer processing a local specialization in an evaluated context even if its first use is in an unevaluated context. But this means we need to avoid walking a tree that already has extra args/specs saved because the list of saved specs appears to be an evaluated context which we'll now walk first. It seems then that we should be calculating the saved specs from scratch each time, rather than potentially walking the saved specs list from an earlier partial instantiation when calling build_extra_args a second time around. PR c++/114303 gcc/cp/ChangeLog: * constraint.cc (tsubst_requires_expr): Clear REQUIRES_EXPR_EXTRA_ARGS before calling build_extra_args. * pt.cc (tree_extra_args): Define. (extract_locals_r): Assert *_EXTRA_ARGS is empty. (tsubst_stmt) <case IF_STMT>: Clear IF_SCOPE on the new IF_STMT. Call build_extra_args on the new IF_STMT instead of t which might already have IF_STMT_EXTRA_ARGS. gcc/testsuite/ChangeLog: * g++.dg/cpp1z/constexpr-if-lambda6.C: New test. Reviewed-by: Jason Merrill <jason@redhat.com> (cherry picked from commit b262b17636e47ae969a74f16e86ccb00678d5e88)
prev parent reply other threads:[~2024-05-14 2:58 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-11 11:07 [Bug c++/114303] New: ICE with constexpr if and static_assert " benbarsdell at gmail dot com 2024-03-11 12:46 ` [Bug c++/114303] [11/12/13/14 Regression] " pinskia at gcc dot gnu.org 2024-03-11 12:48 ` [Bug c++/114303] [11/12/13/14 Regression] ICE with constexpr if and " pinskia at gcc dot gnu.org 2024-03-11 14:43 ` ppalka at gcc dot gnu.org 2024-03-15 15:01 ` law at gcc dot gnu.org 2024-03-25 12:52 ` rguenth at gcc dot gnu.org 2024-04-11 14:17 ` cvs-commit at gcc dot gnu.org 2024-04-12 20:04 ` [Bug c++/114303] [11/12/13 " ppalka at gcc dot gnu.org 2024-05-14 2:58 ` cvs-commit at gcc dot gnu.org [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-114303-4-EWGWPMgYkX@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).