[Bug driver/114330] New: needs_preprocessing field of struct compiler is unused

[Bug driver/114330] New: needs_preprocessing field of struct compiler is unused

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114330

            Bug ID: 114330
           Summary: needs_preprocessing field of struct compiler is unused
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: internal-improvement
          Severity: enhancement
          Priority: P3
         Component: driver
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---

I suspect needs_preprocessing  field became unused when the C preprocessor
became itergrated into the cc1.

while it does not hurt anything to have the field still around and only the
".c" sets it to true, it seems like a decent idea to remove the field.

Also note it might be useful to boolize combinable in struct compiler in gcc.cc
too.

[Bug driver/114330] needs_preprocessing field of struct compiler is unused

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114330

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
[apinski@xeond2 gcc]$ git grep needs_preprocessing
gcc.cc:  int needs_preprocessing;       /* If nonzero, source files need to
lto/lang-specs.h:   /*cpp_spec=*/NULL, /*combinable=*/1,
/*needs_preprocessing=*/0},

That is the only references that grep could find even for needs_preprocessing.

[Bug driver/114330] needs_preprocessing field of struct compiler is unused

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114330

Sam James <sjames at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sjames at gcc dot gnu.org

--- Comment #2 from Sam James <sjames at gcc dot gnu.org> ---
git log -G needs_preprocessing -p indicates r0-102965-gc3224d6f70eefb

[Bug driver/114330] needs_preprocessing field of struct compiler is unused

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114330

--- Comment #3 from Sam James <sjames at gcc dot gnu.org> ---
(I think it was dead before, but it should've been removed by then)

[Bug driver/114330] needs_preprocessing field of struct compiler is unused

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114330

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2024-03-14
             Status|UNCONFIRMED                 |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |pinskia at gcc dot gnu.org

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Sam James from comment #2)
> git log -G needs_preprocessing -p indicates r0-102965-gc3224d6f70eefb

Oh yes when -combine support was removed. It was added in -combine support was
added in r0-57561-g0855eab7a30bb9 . combinable field was added at the same time
but combinable was used afterwards for go (and D and a few others).

So I will handle this for GCC 15. I thought it was added much earlier.

[Bug driver/114330] needs_preprocessing field of struct compiler is unused

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114330

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
The most annoying part of this is the struct compiler is initialized by
*/lang-specs.h and it looks like I missed one and the error message is not so
obvious where the issue is.