From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 209E53858D1E; Thu, 21 Mar 2024 02:25:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 209E53858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1710987929; bh=Rl9BSKWHcLl2bOiYaW8JlABJvXAnIp9mv3y4Zu0zj9o=; h=From:To:Subject:Date:In-Reply-To:References:From; b=DzKj0jQRmnCy7lJwRp2XdOF22vbGzsKb3Yxrw7DeUIzNEzyrl0Hz8yeMzki/hNY46 SYUI0JUaOVJMKnHeM/a36wwkDylwR6trDWQEUxe/uMcoReqhLKczxsCt7v0QfxWJ/K lbR9jhbduMPHjjWkqY1rIrPf22SoOkjonLxNs+Wg= From: "linkw at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/114402] rs6000: ICE when long double is ieee128 format by default but without vsx Date: Thu, 21 Mar 2024 02:25:27 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Version: 14.0 X-Bugzilla-Keywords: ice-on-valid-code X-Bugzilla-Severity: normal X-Bugzilla-Who: linkw at gcc dot gnu.org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: linkw at gcc dot gnu.org X-Bugzilla-Target-Milestone: 15.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D114402 --- Comment #1 from Kewen Lin --- Currently the only pattern to match IEEE128 comparison is: ;; IEEE 128-bit comparisons (define_insn "*cmp_hw" [(set (match_operand:CCFP 0 "cc_reg_operand" "=3Dy") (compare:CCFP (match_operand:IEEE128 1 "altivec_register_operand" "= v") (match_operand:IEEE128 2 "altivec_register_operand" "v")))] "TARGET_FLOAT128_HW && FLOAT128_IEEE_P (mode)" "xscmpuqp %0,%1,%2" [(set_attr "type" "veccmp") (set_attr "size" "128")]) It requires TARGET_FLOAT128_HW, so nothing can be used for matching. The below patch can fix this ICE, it makes no-vsx IEEE128 also go with libf= unc call like !TARGET_FLOAT128_HW && FLOAT128_VECTOR_P (mode). diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc index 5d975dab921..237d138faec 100644 --- a/gcc/config/rs6000/rs6000.cc +++ b/gcc/config/rs6000/rs6000.cc @@ -15329,7 +15329,7 @@ rs6000_generate_compare (rtx cmp, machine_mode mode) rtx op0 =3D XEXP (cmp, 0); rtx op1 =3D XEXP (cmp, 1); - if (!TARGET_FLOAT128_HW && FLOAT128_VECTOR_P (mode)) + if (!TARGET_FLOAT128_HW && FLOAT128_IEEE_P (mode)) comp_mode =3D CCmode; else if (FLOAT_MODE_P (mode)) comp_mode =3D CCFPmode; @@ -15361,7 +15361,7 @@ rs6000_generate_compare (rtx cmp, machine_mode mode) /* IEEE 128-bit support in VSX registers when we do not have hardware support. */ - if (!TARGET_FLOAT128_HW && FLOAT128_VECTOR_P (mode)) + if (!TARGET_FLOAT128_HW && FLOAT128_IEEE_P (mode)) { rtx libfunc =3D NULL_RTX; bool check_nan =3D false;=