From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 985233858D38; Fri, 22 Mar 2024 00:01:18 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 985233858D38
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1711065678;
	bh=mxTE/euphpw3SRLD47fGXhCZFEmTmzFmGatEt+DN6Hs=;
	h=From:To:Subject:Date:From;
	b=grViTCFA3/s8qnrDda9spGJUAPas6dGq7iN9l7SOTshnTVBgH/SXxX7ZEqF5V1v3L
	 RzfQYQPGyGrATVkbm1rIpqCImfz5eDmJrqdOtcJS/gV+WaygYvfKnajk/W7tmO6HKy
	 N+DxbfuJXD8yiVaG2czHE9i7+mL95OOSXQnk8tF0=
From: "doko at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ada/114424] New: gnat: Ada.Calendar.Clock crashes on 32bit
 architectures with 64bit time_t
Date: Fri, 22 Mar 2024 00:01:16 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ada
X-Bugzilla-Version: 13.2.1
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: doko at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter cc target_milestone
Message-ID: <bug-114424-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D114424

            Bug ID: 114424
           Summary: gnat: Ada.Calendar.Clock crashes on 32bit
                    architectures with 64bit time_t
           Product: gcc
           Version: 13.2.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
          Assignee: unassigned at gcc dot gnu.org
          Reporter: doko at gcc dot gnu.org
                CC: dkm at gcc dot gnu.org
  Target Milestone: ---

[forwarded from https://bugs.debian.org/1067453]

Ada packages randomly FTBFS on 32 bit architectures with
gprbuild: raised CONSTRAINT_ERROR : a-calend.adb:371 overflow check failed

The problem originates in the gcc-13 switch to time_t64.
gcc/ada/libgnat/s-os_prim__posix.adb is affected by two apparently
distinct issues.

* s-os_prim.adb allocates 3Long_Integer=3D3void*=3D3*32 bits for the
  timeval C struct, while 2*64bits =3D 2Long_Long_Integer are now needed.

  This issue affects other files, but is easy to find and fix.

* The switch breaks the call from Ada to the C gettimeofday function.

  Can anyone explain this, and ideally provide a real fix instead of
  the ugly work-around below?

cat > mycal.c <<EOF
#include <sys/time.h>
int mygettimeofday(struct timeval *restrict tv,
                   struct timezone *restrict tz) {
  return gettimeofday(tv, tz);
}
EOF

cat > foo.adb <<EOF
with Ada.Text_IO, System.OS_Primitives;
procedure Foo is
   -- On armhf, array(1..3) of Long_Integer gives random usec values.
   type timeval is array (1 .. 2) of Long_Long_Integer;
   procedure timeval_to_duration
     (T    : not null access timeval;
      sec  : not null access Long_Long_Integer;
      usec : not null access Long_Integer);
   pragma Import (C, timeval_to_duration, "__gnat_timeval_to_duration");
   sec    : aliased Long_Long_Integer;
   usec   : aliased Long_Integer;
   TV     : aliased timeval;
   function gettimeofday (Tv : access timeval;
      Tz : System.Address :=3D System.Null_Address) return Integer;
   -- On armhf, a direct import of gettimeofday leads to random Tv values.
   pragma Import (C, gettimeofday, "mygettimeofday");
   Result : constant Integer :=3D gettimeofday (TV'Access, System.Null_Addr=
ess);
   SOP : constant Duration :=3D System.OS_Primitives.Clock;
begin
   timeval_to_duration (TV'Access, sec'Access, usec'Access);
   Ada.Text_IO.Put_Line ("local               :" & Sec'Img & "." & Usec'Img=
);
   Ada.Text_IO.Put_Line ("System.OS_Primitives:" & SOP'Img);
end Foo;
EOF

gcc -c mycal.c -o mycal.o
gnatmake -gnat2022 foo -largs mycal.o
echo -n 'Machine             : '; uname -m
date   '+Expected            : %s'
./foo

Machine             : x86_64  (amd64 x86_64-linux-gnu)
Expected            : 1711035183
local               : 1711035183. 324545
System.OS_Primitives: 1711035183.324549000

Machine             : armv7l  (armhf arm-gnu-eabi)
Expected            : 1711035189
local               : 1711035189. 551691
System.OS_Primitives: 1113580361.675821568=