[Bug c++/114426] [14 regression] ICE when building log4cxx on arm (cxx_eval_call_expression, at cp/constexpr.cc:3242) since r14-6507

["jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114426

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
2024-03-22  Jakub Jelinek  <jakub@redhat.com>

        PR c++/114426
        * cp-gimplify.cc (cp_fold): Don't call maybe_const_value on
        CALL_EXPRs to cdtors.

        * g++.dg/cpp2a/pr114426.C: New test.

--- gcc/cp/cp-gimplify.cc.jj    2024-02-23 18:55:05.377594277 +0100
+++ gcc/cp/cp-gimplify.cc       2024-03-22 16:46:49.381442914 +0100
@@ -3395,7 +3395,14 @@ cp_fold (tree x, fold_flags_t flags)
           Do constexpr expansion of expressions where the call itself is not
           constant, but the call followed by an INDIRECT_REF is.  */
        if (callee && DECL_DECLARED_CONSTEXPR_P (callee)
-           && !flag_no_inline)
+           && !flag_no_inline
+           /* Don't invoke it on cdtors.  On
+              !targetm.cxx.cdtor_returns_this () it won't do anything as it
+              has void type, so don't do it on
+              targetm.cxx.cdtor_returns_this () targets either for
+              consistency.  */
+           && !DECL_CONSTRUCTOR_P (callee)
+           && !DECL_DESTRUCTOR_P (callee))
          {
            mce_value manifestly_const_eval = mce_unknown;
            if (flags & ff_mce_false)
--- gcc/testsuite/g++.dg/cpp2a/pr114426.C.jj    2024-03-22 16:49:55.650882841
+0100
+++ gcc/testsuite/g++.dg/cpp2a/pr114426.C       2024-03-22 16:48:51.829759997
+0100
@@ -0,0 +1,6 @@
+// PR c++/114426
+// { dg-do compile }
+
+struct A { virtual ~A (); };
+struct B : virtual A { virtual void foo () = 0; };
+struct C : B { C () {} };

fixes the ICE, but dunno whether something different shouldn't be done instead.