public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jchrist at linux dot ibm.com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/114435] PCOM messes up vectorization some times Date: Wed, 29 May 2024 08:03:44 +0000 [thread overview] Message-ID: <bug-114435-4-ZqbebWK5Pm@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-114435-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114435 --- Comment #2 from jchrist at linux dot ibm.com --- I tried this, but it seems like pcom does not handle vectors at all: In the gimple input I have vectp.5_32 = r_26(D); # VUSE <.MEM_52> vect__51.6_1 = MEM <vector(2) doubleD.32> [(doubleD.32 *)vectp.5_32]; # PT = nonlocal null # ALIGN = 8, MISALIGN = 0 vectp.5_2 = vectp.5_32 + 16; # VUSE <.MEM_52> vect__51.7_3 = MEM <vector(2) doubleD.32> [(doubleD.32 *)vectp.5_2]; [...] vectp.15_12 = r_26(D); # .MEM_13 = VDEF <.MEM_52> MEM <vector(2) doubleD.32> [(doubleD.32 *)vectp.15_12] = vect__45.13_11; # PT = nonlocal null # ALIGN = 8, MISALIGN = 0 vectp.15_14 = vectp.15_12 + 16; # .MEM_15 = VDEF <.MEM_13> MEM <vector(2) doubleD.32> [(doubleD.32 *)vectp.15_14] = vect__45.13_29; But the analyzed data dependencies are: (Data Dep: #(Data Ref: # bb: 9 # stmt: vect__51.6_1 = MEM <vector(2) double> [(double *)vectp.5_32]; # ref: MEM <vector(2) double> [(double *)vectp.5_32]; # base_object: MEM <vector(2) double> [(double *)vectp.5_32]; #) #(Data Ref: # bb: 9 # stmt: MEM <vector(2) double> [(double *)vectp.15_12] = vect__45.13_11; # ref: MEM <vector(2) double> [(double *)vectp.15_12]; # base_object: MEM <vector(2) double> [(double *)vectp.15_12]; #) (don't know) ) (Data Dep: #(Data Ref: # bb: 9 # stmt: vect__51.7_3 = MEM <vector(2) double> [(double *)vectp.5_2]; # ref: MEM <vector(2) double> [(double *)vectp.5_2]; # base_object: MEM <vector(2) double> [(double *)vectp.5_2]; #) #(Data Ref: # bb: 9 # stmt: MEM <vector(2) double> [(double *)vectp.15_14] = vect__45.13_29; # ref: MEM <vector(2) double> [(double *)vectp.15_14]; # base_object: MEM <vector(2) double> [(double *)vectp.15_14]; #) (don't know) ) Is this expected? Because I think this is the reason why the generated code is still not optimal. In every loop iteration, we still load the two accumulation vectors on s390x, just to use them for fma and then store them. If I understand commoning correctly, this would be one case where it should solve this problem and improve the code by loading and storing the accumulator outside of the loop.
next prev parent reply other threads:[~2024-05-29 8:03 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-22 17:17 [Bug tree-optimization/114435] New: Bad code generated when SSA and PCOM are enabled jchrist at linux dot ibm.com 2024-03-25 8:52 ` [Bug tree-optimization/114435] PCOM messes up vectorization some times rguenth at gcc dot gnu.org 2024-05-29 8:03 ` jchrist at linux dot ibm.com [this message] 2024-05-29 8:23 ` rguenth at gcc dot gnu.org 2024-05-29 8:34 ` rguenth at gcc dot gnu.org 2024-05-29 9:25 ` jchrist at linux dot ibm.com 2024-05-29 10:43 ` rguenth at gcc dot gnu.org 2024-05-29 10:55 ` rguenth at gcc dot gnu.org 2024-05-29 10:58 ` cvs-commit at gcc dot gnu.org 2024-05-29 11:07 ` rguenth at gcc dot gnu.org 2024-05-29 11:10 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-114435-4-ZqbebWK5Pm@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).