From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 8D48A3858C36; Thu, 28 Mar 2024 00:40:04 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8D48A3858C36
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1711586404;
	bh=yb7YcmIh1Cxir+tjvV/WlGXxalAYAWYhFCtkFnTSTYg=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=fJI1xxs2QAC4YxXnDTqJ8XZJq35PvjSLo/6HJBNC9h4C3wJM3dD6KuqxzvaXnQdTJ
	 U20E8YPGTMUfgVcZk48IspF4Zk1CuxiM6GJmtl5V7Auj1RoYatolic7KsbGPJv62y1
	 phmEK923iaUJR3v7A/+PY2jSgoSb3qTOFPPHAGdQ=
From: "eschwartz93 at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/114505] static archives built with gcc --without-zstd cause
 ICE when read by gcc with zstd support
Date: Thu, 28 Mar 2024 00:40:03 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: lto
X-Bugzilla-Version: 13.2.1
X-Bugzilla-Keywords: lto, needs-reduction
X-Bugzilla-Severity: normal
X-Bugzilla-Who: eschwartz93 at gmail dot com
X-Bugzilla-Status: WAITING
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-114505-4-CGQGHs4YMK@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-114505-4@http.gcc.gnu.org/bugzilla/>
References: <bug-114505-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D114505

--- Comment #12 from Eli Schwartz <eschwartz93 at gmail dot com> ---
(In reply to Xi Ruoyao from comment #1)
> Confirmed as I've seen it before.  At least we should turn it into a
> "normal" error message instead of ICE.
>=20
> But note that even "downgrading the compression algorithm" is supported, =
it
> won't really help rolling-release distros.  When GCC itself is upgraded w=
ith
> a LTO API version change, all previous LTO static archives will be unusab=
le
> anyway.  Generally the distros should not ship LTO static archives at all.

Agreed, figuring out how to solve that is an open ticket too:
https://bugs.gentoo.org/926120

Still would like to solve the zstd case :D especially since I am sure given=
 the
flexibility of a from-source distro there will be users who insist they'd
rather rebuild the entire OS on a GCC upgrade, so reducing the compression
algorithm edge case will come in use.


(In reply to Andrew Pinski from comment #2)
> On the input side:
> Wait this should not happen.
>=20
>       lto_end_uncompression (stream,
>                              file_data->lto_section_header.get_compression
> ());


I cannot swear this was the case but the error very specifically occurred as
part of a Gentoo profile change that caused zstd to be enabled.

The version of zstd should be the same, at least...=