public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "gaius at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug modula2/114520] Incorrect ordering of import/export statements cause confusing error messages
Date: Thu, 28 Mar 2024 16:25:55 +0000	[thread overview]
Message-ID: <bug-114520-4-2SoThz0Xdj@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-114520-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114520

--- Comment #2 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 57832
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57832&action=edit
Proposed fix

The error recovery causes misleading error messages to appear if an EXPORT
and IMPORT statement are in the wrong order.  This patch detects the
incorrect order and issues an error message and prevents error recovery.
The fix should be improved and made more general if another similar
case is required.

gcc/m2/ChangeLog:

        * gm2-compiler/P0SyntaxCheck.bnf (DetectImport): New procedure.
        (EnableImportCheck): New boolean.
        (Expect): Call DetectImport.
        (Export): Set EnableImportCheck TRUE before ';' and FALSE
        afterwards.

  parent reply	other threads:[~2024-03-28 16:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28 15:46 [Bug modula2/114520] New: " gaius at gcc dot gnu.org
2024-03-28 15:46 ` [Bug modula2/114520] " gaius at gcc dot gnu.org
2024-03-28 16:25 ` gaius at gcc dot gnu.org [this message]
2024-03-28 16:29 ` gaius at gcc dot gnu.org
2024-03-28 16:50 ` cvs-commit at gcc dot gnu.org
2024-03-28 16:52 ` gaius at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-114520-4-2SoThz0Xdj@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).