From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 877FC3858417; Sun, 21 Apr 2024 04:09:08 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 877FC3858417
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1713672548;
	bh=++wcilS8e0Mf9oUZQF/RdJTFt+bvJvXjPY6BV7qZ8Os=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=UcnMYa4qTJYKQkpkqjaqdmxZTMeONUUX5zw3qMvjbknxRbSoB09hyeyHFsTy73j1i
	 KDRDzj27v85j2sUIEGNfLJsKpFS67DrkwLGTeCKu5ShtS57JKGzn2oMJ8wPcQU9yEp
	 /TqER4/X0gpEXvwadXxp8xJaXgC+2wMauf/mGNOI=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/114580] Bogus warning on if constexpr
Date: Sun, 21 Apr 2024 04:09:05 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 14.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-114580-4-XPNZ1XaYdY@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-114580-4@http.gcc.gnu.org/bugzilla/>
References: <bug-114580-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D114580

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:ae3b6dea0445f9650cf1a684527efac06497f1b4

commit r13-8629-gae3b6dea0445f9650cf1a684527efac06497f1b4
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Apr 9 09:31:42 2024 +0200

    c++: Fix up maybe_warn_for_constant_evaluated calls [PR114580]

    When looking at maybe_warn_for_constant_evaluated for the trivial
    infinite loops patch, I've noticed that it can emit weird diagnostics
    for if constexpr in templates, first warn that std::is_constant_evalute=
d()
    always evaluates to false (because the function template is not constex=
pr)
    and then during instantiation warn that std::is_constant_evaluted()
    always evaluates to true (because it is used in if constexpr condition).
    Now, only the latter is actually true, even when the if constexpr
    is in a non-constexpr function, it will still always evaluate to true.

    So, the following patch fixes it to call maybe_warn_for_constant_evalua=
ted
    always with IF_STMT_CONSTEXPR_P (if_stmt) as the second argument rather
than
    true if it is if constexpr with non-dependent condition etc.

    2024-04-09  Jakub Jelinek  <jakub@redhat.com>

            PR c++/114580
            * semantics.cc (finish_if_stmt_cond): Call
            maybe_warn_for_constant_evaluated with IF_STMT_CONSTEXPR_P
(if_stmt)
            as the second argument, rather than true/false depending on if
            it is if constexpr with non-dependent constant expression with
            bool type.

            * g++.dg/cpp2a/is-constant-evaluated15.C: New test.

    (cherry picked from commit cfed80b9e4f562c99679739548df9369117dd791)=