public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libquadmath/114623] sqrtq and std::numeric_limits<__float128>::max()
Date: Mon, 08 Apr 2024 08:42:20 +0000	[thread overview]
Message-ID: <bug-114623-4-xVKupzeguB@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-114623-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114623

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #3)
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83800#c4
> 
> Basically libquadmath should be using sqrt128f if it exist for sqrtq instead
> of doing a version itself ...

That doesn't make any sense.
sqrtf128 is only available in recent glibcs, not in any other C library.
libquadmath by design contains copies of the (old) glibc IEEE754 quad code, so
that
it provides the support independently from the C library.  Has been doing that
before
any *f128 support has been added to glibc, and needs to do it even now to
support other C libraries.
The sqrt* case was an exception, the glibc sysdeps/ieee754/ldbl-128/ didn't
contain any sqrt implementation, as arches which supported ldbl-128 as long
double at that point had hw sqrt support, so libquadmath has just an
approximation.
What could be done is use the soft-fp implementation like is done even in glibc
for x86.  We have the soft-fp code in gcc, but would need to arrange the right
sfp-machine.h etc.

  parent reply	other threads:[~2024-04-08  8:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-07  4:03 [Bug libquadmath/114623] New: sqrt g.peterhoff@t-online.de
2024-04-07  4:15 ` [Bug libquadmath/114623] sqrt pinskia at gcc dot gnu.org
2024-04-07  4:22 ` [Bug libquadmath/114623] sqrtq and std::numeric_limits<__float128>::max() g.peterhoff@t-online.de
2024-04-07  4:41 ` pinskia at gcc dot gnu.org
2024-04-07  5:20 ` g.peterhoff@t-online.de
2024-04-08  8:42 ` jakub at gcc dot gnu.org [this message]
2024-04-08 11:27 ` jakub at gcc dot gnu.org
2024-04-08 11:30 ` jakub at gcc dot gnu.org
2024-04-09  6:22 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-114623-4-xVKupzeguB@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).