public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/114635] OpenMP reductions fail dependency analysis
Date: Mon, 08 Apr 2024 12:32:14 +0000	[thread overview]
Message-ID: <bug-114635-4-8qzwT4GA6b@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-114635-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114635

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
The OpenMP safelen clause argument is a scalar integer, so using poly_int for
something that must be an int doesn't make sense.
Though, the above testcase actually doesn't use safelen clause, so safelen is
there effectively infinity.
The issue is how we represent the clauses like reduction on simd.
The design is that they are represented as initially large magic "omp simd
array" arrays with constant number of iterations derived from the maximum
possible vectorization factor, and then the vectorizer either shrinks those two
the actual vectorization factor (if different from the old constant) or to [1]
array if vectorization wasn't possible and we've in fact used vectorization
factor of 1.

Now, with SVE/RISCV vectors the actual vectorization factor is a poly_int
rather than constant.  One possibility would be to use VLA arrays in those
cases, but then it will be hard to undo that later, or allow both shrinking and
growing the arrays and even turning them into VLA-like ones.

  parent reply	other threads:[~2024-04-08 12:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08  9:58 [Bug tree-optimization/114635] New: " tnfchris at gcc dot gnu.org
2024-04-08 12:02 ` [Bug tree-optimization/114635] " rguenth at gcc dot gnu.org
2024-04-08 12:19 ` rguenth at gcc dot gnu.org
2024-04-08 12:26 ` rguenth at gcc dot gnu.org
2024-04-08 12:32 ` jakub at gcc dot gnu.org [this message]
2024-04-08 12:35 ` jakub at gcc dot gnu.org
2024-04-08 14:55 ` tnfchris at gcc dot gnu.org
2024-04-08 15:36 ` rguenther at suse dot de
2024-04-10  6:53 ` kugan at gcc dot gnu.org
2024-04-15  7:44 ` kugan at gcc dot gnu.org
2024-04-15  7:45 ` kugan at gcc dot gnu.org
2024-04-15  7:49 ` jakub at gcc dot gnu.org
2024-04-15  7:57 ` kugan at gcc dot gnu.org
2024-04-15  8:00 ` jakub at gcc dot gnu.org
2024-04-15  8:06 ` rguenth at gcc dot gnu.org
2024-04-15  8:08 ` rguenther at suse dot de
2024-04-15  8:14 ` jakub at gcc dot gnu.org
2024-04-15  8:18 ` rguenther at suse dot de
2024-04-15  9:06 ` kugan at gcc dot gnu.org
2024-05-14 15:24 ` rsandifo at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-114635-4-8qzwT4GA6b@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).