public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "kugan at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/114635] OpenMP reductions fail dependency analysis
Date: Mon, 15 Apr 2024 09:06:27 +0000	[thread overview]
Message-ID: <bug-114635-4-CoFwDUei1m@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-114635-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114635

--- Comment #18 from kugan at gcc dot gnu.org ---
Also, can we set INT_MAX when there is no explicit safelen specified in OMP.
Something like:

--- a/gcc/omp-low.cc
+++ b/gcc/omp-low.cc
@@ -6975,14 +6975,11 @@ lower_rec_input_clauses (tree clauses, gimple_seq
*ilist, gimple_seq *dlist,
     {
       tree c = omp_find_clause (gimple_omp_for_clauses (ctx->stmt),
                                OMP_CLAUSE_SAFELEN);
-      poly_uint64 safe_len;
-      if (c == NULL_TREE
-         || (poly_int_tree_p (OMP_CLAUSE_SAFELEN_EXPR (c), &safe_len)
-             && maybe_gt (safe_len, sctx.max_vf)))
+      if (c == NULL_TREE)
        {
          c = build_omp_clause (UNKNOWN_LOCATION, OMP_CLAUSE_SAFELEN);
          OMP_CLAUSE_SAFELEN_EXPR (c) = build_int_cst (integer_type_node,
-                                                      sctx.max_vf);
+                                                      INT_MAX);
          OMP_CLAUSE_CHAIN (c) = gimple_omp_for_clauses (ctx->stmt);
          gimple_omp_for_set_clauses (ctx->stmt, c);
        }

  parent reply	other threads:[~2024-04-15  9:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08  9:58 [Bug tree-optimization/114635] New: " tnfchris at gcc dot gnu.org
2024-04-08 12:02 ` [Bug tree-optimization/114635] " rguenth at gcc dot gnu.org
2024-04-08 12:19 ` rguenth at gcc dot gnu.org
2024-04-08 12:26 ` rguenth at gcc dot gnu.org
2024-04-08 12:32 ` jakub at gcc dot gnu.org
2024-04-08 12:35 ` jakub at gcc dot gnu.org
2024-04-08 14:55 ` tnfchris at gcc dot gnu.org
2024-04-08 15:36 ` rguenther at suse dot de
2024-04-10  6:53 ` kugan at gcc dot gnu.org
2024-04-15  7:44 ` kugan at gcc dot gnu.org
2024-04-15  7:45 ` kugan at gcc dot gnu.org
2024-04-15  7:49 ` jakub at gcc dot gnu.org
2024-04-15  7:57 ` kugan at gcc dot gnu.org
2024-04-15  8:00 ` jakub at gcc dot gnu.org
2024-04-15  8:06 ` rguenth at gcc dot gnu.org
2024-04-15  8:08 ` rguenther at suse dot de
2024-04-15  8:14 ` jakub at gcc dot gnu.org
2024-04-15  8:18 ` rguenther at suse dot de
2024-04-15  9:06 ` kugan at gcc dot gnu.org [this message]
2024-05-14 15:24 ` rsandifo at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-114635-4-CoFwDUei1m@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).